fix: when rayJobInstance.Spec.RayClusterSpec is nil, kuberay operator crash (#4102)

KunWuLuan · web-flow · commit 774b9173401f · 2025-09-30T22:49:58.000+08:00
Signed-off-by: KunWuLuan &lt;kunwuluan@gmail.com&gt;
diff --git a/ray-operator/controllers/ray/common/job.go b/ray-operator/controllers/ray/common/job.go
@@ -164,7 +164,7 @@ func BuildJobSubmitCommand(rayJobInstance *rayv1.RayJob, submissionMode rayv1.Jo
 		cmd = append(cmd, "--runtime-env-json", strconv.Quote(runtimeEnvJson))
 	}
 
-	if len(metadata) > 0 {
+	if len(metadata) > 0 && rayJobInstance.Spec.RayClusterSpec != nil {
 		metadataJson, err := GetMetadataJson(metadata, rayJobInstance.Spec.RayClusterSpec.RayVersion)
 		if err != nil {
 			return nil, err

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ func BuildJobSubmitCommand(rayJobInstance *rayv1.RayJob, submissionMode rayv1.Jo`
`164`	`164`	`cmd = append(cmd, "--runtime-env-json", strconv.Quote(runtimeEnvJson))`
`165`	`165`	`}`
`166`	`166`
`167`		`- if len(metadata) > 0 {`
	`167`	`+ if len(metadata) > 0 && rayJobInstance.Spec.RayClusterSpec != nil {`
`168`	`168`	`metadataJson, err := GetMetadataJson(metadata, rayJobInstance.Spec.RayClusterSpec.RayVersion)`
`169`	`169`	`if err != nil {`
`170`	`170`	`return nil, err`