Skip to content

Commit 9bd753c

Browse files
authored
feat: hidden the grafana dashboard if link is not provided (#4094)
Signed-off-by: Cheyu Wu <cheyu1220@gmail.com>
1 parent 536ca35 commit 9bd753c

File tree

2 files changed

+34
-30
lines changed

2 files changed

+34
-30
lines changed

dashboard/src/components/ClustersTable/ClustersTable.tsx

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -123,21 +123,23 @@ export const ClustersTable = () => {
123123
/>
124124
</IconButton>
125125
)}
126-
<IconButton
127-
variant="plain"
128-
size="sm"
129-
sx={{
130-
minHeight: "1rem",
131-
minWidth: "1rem",
132-
px: 0.5,
133-
}}
134-
title="Grafana Metrics"
135-
href={row.links.rayGrafanaDashboardLink}
136-
target="_blank"
137-
component="a"
138-
>
139-
<Image priority src={GrafanaIcon} alt="Grafana Metrics" />
140-
</IconButton>
126+
{row.links.rayGrafanaDashboardLink && (
127+
<IconButton
128+
variant="plain"
129+
size="sm"
130+
sx={{
131+
minHeight: "1rem",
132+
minWidth: "1rem",
133+
px: 0.5,
134+
}}
135+
title="Grafana Metrics"
136+
href={row.links.rayGrafanaDashboardLink}
137+
target="_blank"
138+
component="a"
139+
>
140+
<Image priority src={GrafanaIcon} alt="Grafana Metrics" />
141+
</IconButton>
142+
)}
141143
</td>
142144
</>
143145
);

dashboard/src/components/JobsTable/JobsTable.tsx

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -120,21 +120,23 @@ export const JobsTable = () => {
120120
/>
121121
</IconButton>
122122
)}
123-
<IconButton
124-
variant="plain"
125-
size="sm"
126-
sx={{
127-
minHeight: "1rem",
128-
minWidth: "1rem",
129-
px: 0.5,
130-
}}
131-
title="Grafana Metrics"
132-
href={row.links.rayGrafanaDashboardLink}
133-
target="_blank"
134-
component="a"
135-
>
136-
<Image priority src={GrafanaIcon} alt="Grafana Metrics" />
137-
</IconButton>
123+
{row.links.rayGrafanaDashboardLink && (
124+
<IconButton
125+
variant="plain"
126+
size="sm"
127+
sx={{
128+
minHeight: "1rem",
129+
minWidth: "1rem",
130+
px: 0.5,
131+
}}
132+
title="Grafana Metrics"
133+
href={row.links.rayGrafanaDashboardLink}
134+
target="_blank"
135+
component="a"
136+
>
137+
<Image priority src={GrafanaIcon} alt="Grafana Metrics" />
138+
</IconButton>
139+
)}
138140
<IconButton
139141
variant="plain"
140142
size="sm"

0 commit comments

Comments
 (0)