Add IdentityServer data migrator#9
Open
lukaszdobrzynski wants to merge 4 commits intoravendb:masterfrom
Open
Conversation
lukaszdobrzynski
force-pushed
the
master
branch
2 times, most recently
from
94cb747 to
28bf214
Compare
lukaszdobrzynski
force-pushed
the
master
branch
from
28bf214 to
8021b11
Compare
ayende
reviewed
Aug 22, 2021
|
|
||
| if (documentStore.Certificate != null) | ||
| { | ||
| documentStore.AfterDispose += (sender, args) => |
Collaborator
Author
There was a problem hiding this comment.
I believe it is a user that should be responsible for defining the handler's logic and be aware that a certificate needs to be displosed of along with the displosal of the document store. Do you think the library should perform the check and displose of the resource quitely?
Member
There was a problem hiding this comment.
The problem is that if this isn't disposed, there is a temp file that isn't being cleaned.
This is probably disposed because otherwise users tend to not pat attention to that.
Collaborator
Author
There was a problem hiding this comment.
👍 reverted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IdentityServerDataMigrator is an extra feature to make transition from in-memory configuration to
RavenDBeasier.Also decided that it is a user that should be responsible for registering
AfterDisposehandler and its logic.