Make Pro empty-response recovery reliable by default - #2
Closed
cinnabarhorse wants to merge 1 commit into
Closed
Conversation
Author
|
Closing while the local empty-response recovery is validated against a real Pro turn. The branch is intentionally retained for reopening if validation passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix intermittent false
EMPTY_RESPONSEresults from long Pro turns whose initial SSE stream completes before the final assistant message is available.--temporary,--save,--keep-conversation, and continued-conversation behavior stays opt-in and unchanged.--retriesis enabled.This builds on #1, extending reconciliation to the default call path where the reported failures occur while retaining clean ChatGPT history.
Verification
bun run checktsc --noEmitpassed