Skip to content

Fix incorrect properties in Hibernate second level article #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rashidi merged 1 commit into from
Jul 19, 2025
Merged

Fix incorrect properties in Hibernate second level article #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data-jpa-hibernate-cache/README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ spring.jpa.properties.hibernate.cache.use_second_level_cache=true
These properties configure Hibernate to:

* Use JCache as the caching implementation (`hibernate.cache.region.factory_class=jcache`)
* Use the EhCache configuration file located at `/ehcache.xml` (`hibernate.javax.cache.uri=/ehcache.xml`)
* Use EhCache as the JCache provider (`hibernate.javax.cache.provider=org.ehcache.jsr107.EhcacheCachingProvider`)
* Use the EhCache configuration file located at `/ehcache.xml` (`hibernate.cache.jcache.uri=/ehcache.xml`)
Copy link

@gemini-code-assist gemini-code-assist bot Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the property name is now correct, the description for hibernate.cache.jcache.uri is slightly redundant. It mentions the configuration file path /ehcache.xml, which is also shown as the property's value. For better conciseness and consistency with other items in the list, consider rephrasing this line.

* Specify the EhCache configuration file URI (`hibernate.cache.jcache.uri=/ehcache.xml`)

* Use EhCache as the JCache provider (`hibernate.cache.jcache.provider=org.ehcache.jsr107.EhcacheCachingProvider`)
* Enable the second-level cache (`hibernate.cache.use_second_level_cache=true`)

=== EhCache Configuration
Expand Down
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/data-jpa-hibernate-cache.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ spring.jpa.properties.hibernate.cache.use_second_level_cache=true
These properties configure Hibernate to:

* Use JCache as the caching implementation (`hibernate.cache.region.factory_class=jcache`)
* Use the EhCache configuration file located at `/ehcache.xml` (`hibernate.javax.cache.uri=/ehcache.xml`)
* Use EhCache as the JCache provider (`hibernate.javax.cache.provider=org.ehcache.jsr107.EhcacheCachingProvider`)
* Use the EhCache configuration file located at `/ehcache.xml` (`hibernate.cache.jcache.uri=/ehcache.xml`)
Copy link

@gemini-code-assist gemini-code-assist bot Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the property name is now correct, the description for hibernate.cache.jcache.uri is slightly redundant. It mentions the configuration file path /ehcache.xml, which is also shown as the property's value. For better conciseness and consistency with other items in the list, consider rephrasing this line.

* Specify the EhCache configuration file URI (`hibernate.cache.jcache.uri=/ehcache.xml`)

* Use EhCache as the JCache provider (`hibernate.cache.jcache.provider=org.ehcache.jsr107.EhcacheCachingProvider`)
* Enable the second-level cache (`hibernate.cache.use_second_level_cache=true`)

=== EhCache Configuration
Expand Down
Loading