Source install selector from platform support data#802
Open
bdice wants to merge 6 commits into
Open
Conversation
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
rockhowse
approved these changes
Jun 30, 2026
rockhowse
left a comment
Contributor
There was a problem hiding this comment.
ok did a quick review, just so I understand a bit more
-
- has been ✅ + :git-merged:
- was a pre-req to provide data we are basically already using to test nightlies
adds "nightly" data to the Platform Support
-
#802 was a fast follow
- uses the _data/platform_support.yml as the source of truth for both release and nightly (new)
- removes the data embedded the selector
- now includes a python helper script and pre-check to validate the metadata matches reality?
- simplifies the logic internally on this page
- Reviewed the render in the PR and it looks to be good and install selector is working as expected
Makes sense to me and is basically what I was trying to articulate we do for things like this during the build meeting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The install selector duplicated platform support values across several hardcoded arrays and a separate Conda CUDA bounds object. Serializing the existing Jekyll data keeps
_data/platform_support.ymlas the single source for supported Python and CUDA values without introducing another generated JSON artifact.Validation
pre-commit run --all-files