Skip to content

Enforce smaller wheel sizes#2089

Merged
rapids-bot[bot] merged 2 commits into
rapidsai:mainfrom
KyleFromNVIDIA:enforce-smaller-wheel-sizes
May 15, 2026
Merged

Enforce smaller wheel sizes#2089
rapids-bot[bot] merged 2 commits into
rapidsai:mainfrom
KyleFromNVIDIA:enforce-smaller-wheel-sizes

Conversation

@KyleFromNVIDIA
Copy link
Copy Markdown
Member

@KyleFromNVIDIA KyleFromNVIDIA commented May 14, 2026

Ensure that the wheel sizes do not creep back above these thresholds so we can hold onto our hard-won size savings.

Ensure that the wheel sizes do not creep back above these thresholds
and hold onto our hard-won size savings.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner May 14, 2026 22:25
@KyleFromNVIDIA KyleFromNVIDIA requested a review from gforsyth May 14, 2026 22:25
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 14, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 994af2cd-07ba-4fcb-be6c-d4e533b96f0c

📥 Commits

Reviewing files that changed from the base of the PR and between 1b748a3 and 48255ed.

📒 Files selected for processing (1)
  • ci/validate_wheel.sh

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Tightened package size validation limits for Python wheel distributions to enforce stricter size constraints during build validation.

Walkthrough

The PR tightens wheel size validation limits in the CI validation script for python/libcuvs wheels. The pydistcheck maximum compressed size thresholds are reduced for both CUDA 12 (from 400Mi to 350Mi) and non-CUDA 12 targets (from 250Mi to 220Mi).

Changes

Wheel Size Validation Tightening

Layer / File(s) Summary
Wheel size limits
ci/validate_wheel.sh
The pydistcheck --max-allowed-size-compressed argument is tightened for CUDA 12 from 400Mi to 350Mi and for other CUDA versions from 250Mi to 220Mi.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: tightening wheel size limits in the validation script to enforce stricter size constraints.
Description check ✅ Passed The description explains the purpose of enforcing wheel size thresholds and mentions hard-won size savings, relating directly to the changeset's goal of preventing wheel size creep.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@KyleFromNVIDIA
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot Bot merged commit 4c2407f into rapidsai:main May 15, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants