Use @Classpath instead of @CompileClasspath for byteBuddy task inputs#1898
Open
trask wants to merge 1 commit intoraphw:masterfrom
Open
Use @Classpath instead of @CompileClasspath for byteBuddy task inputs#1898trask wants to merge 1 commit intoraphw:masterfrom
trask wants to merge 1 commit intoraphw:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Byte Buddy
Pluginimplementations can read full bytecode and resources from classes on the task'sclassPath— not just their public ABI. The Gradle tasks were annotatinggetClassPath()with@CompileClasspath, which fingerprints inputs using compile-avoidance hashing: method bodies, private members, and resources are normalized away. Two classpaths that share an ABI but differ in method bodies therefore produce the same cache key, causing the task to be reportedUP_TO_DATEeven when its output legitimately depends on the changed bytes.Switch all four task classes (
ByteBuddyTask,ByteBuddyJarTask,ByteBuddyJarsTask,ByteBuddySimpleTask, plus theWithIncrementalClassPathoverride) to@Classpath, which uses full content hashing while still preserving classpath-order semantics.Adds an integration test (
testClassPathFingerprintTracksMethodBodies) that builds a jar, re-runs to confirmUP_TO_DATE, then replaces the jar with a same-ABI/different-body variant and asserts the task re-executes.