fix(snapshot): honor snapshot:false in restore/revert/patch/diff#3
Merged
Merged
Conversation
The snapshot:false config only gated tracking (track/cleanup) but not the restore/revert/patch/diff/diffFull operations. These still ran git read-tree + checkout-index on any stored snapshot hash, crashing on large sessions (e.g. 1800+ messages with 165 file changes) where the snapshot restore exceeded resource limits under spawned (non-TUI) contexts. The config docstring promises 'undoing or reverting will not undo/redo file changes' when snapshot:false, but the implementation broke that promise. Add the missing enabled() guard to all five operations so the config fully disables snapshot filesystem mutations regardless of caller (TUI, opencode run, HTTP API, spawned processes).
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
snapshot: falseconfig was only half-implemented. Theenabled()guard existed ontrack()andcleanup(), but was missing fromrestore(),revert(),patch(),diff(), anddiffFull(). These operations still rangit read-tree+checkout-indexon stored snapshot hashes even when snapshots were explicitly disabled.This caused crashes on large sessions (e.g. 1800+ messages, 165 tracked file changes) when restoring snapshots exceeded resource limits — particularly under spawned/non-TUI contexts (
opencode run, systemd-launched processes).Root cause
Asymmetry in the config gate:
The config docstring already promises "undoing or reverting will not undo/redo file changes" when snapshot:false, but the implementation broke that promise.
Fix
Add
if (!(yield* enabled())) returnto all five unguarded operations, placed outsidelocked()so the semaphore isn't acquired when disabled (matches track()'s pattern). Each returns a typed empty result appropriate to its signature.Verification
opencode run --session— replied to prompts and executed tool calls without the snapshot restore crash