bump go version to 1.25

[farazkhawaja]

Upgrades go version to 1.25
ran go mod tidy on suc/ and suc/pkg/apis folder
ran golangci-lint migrate to migrate golangci config to v2

[brandond]

needs rebase

[brandond]

it looks like some modules will need updates to work with go 1.25

[brandond]

I think you may need to also run go generate if you're updating the controller-gen version.

[farazkhawaja]

@brandond did the CI timeout?

[brandond]

There are regressions (golang/go#75828) in the most recent upstream golang patch releases, we're going to wait for those to be addressed and then we can update again.

[farazkhawaja]

@brandond go 1.25.3 just released. should i change this line from go 1.25.0 to go 1.25.3 . toolchain needs to be changed aswell right?

[brandond]

The bci/golang:1.25 hardcodes GOTOOLCHAIN env var to whatever patch version is in the image. That said, the new patch release isn't available from BCI yet:

brandond@dev01:~$ docker run registry.suse.com/bci/golang:1.25 go version
go version go1.25.2 linux/amd64

[farazkhawaja]

PS C:\Users\pc\Desktop> docker run registry.suse.com/bci/golang:1.25 go version
go version go1.25.2 linux/amd64

@brandond is there any action item from our side to push for 1.25.3?

[hammadsaedi]

fyi; BCI got go 1.25.3

hammad.saeedi@Hammads-MacBook-Pro % docker run registry.suse.com/bci/golang:1.25 go version
go version go1.25.3 linux/arm64

[farazkhawaja]

@brandond

[brandond]

Thanks for sticking with it!

Running: golangci-lint
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.1)
Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.1)
time="2025-11-06T19:42:01Z" level=fatal msg="exit status 3"

need to bump golangci-lint as well, for golang 1.25 compat.

[farazkhawaja]

@brandond we're using v1.64.8 and thats the latest 1.x.x version released by golangci. moving to 2.x.x would mean a major version bump. Do we wanna proceed with that?

[brandond]

Yes, we will need to switch to 2.4 if we want to use go 1.25.

• Ref: go1.25 support golangci/golangci-lint#5873

[brandond]

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

You can't just bump the golangci-lint version, you need to migrate the config from v1 -> v2 as well :/

[farazkhawaja]

@brandond can you kickoff the pipeline again

[brandond]

one change. lgtm otherwise!