Skip to content

Fix: allow creating empty object in GCS #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rameel merged 2 commits into from
Mar 25, 2026
Merged

Fix: allow creating empty object in GCS #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ed56f7
Fix: allow creating empty object in GCS
rameel Mar 25, 2026
0d778dd
Fix: allow creating empty object in GCS
rameel Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions src/Ramstack.FileSystem.Google/GcsWriteStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,8 @@ protected override void Dispose(bool disposing)
{
_stream.Position = 0;

if (_stream.Length != 0)
{
var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };
_fs.StorageClient.UploadObject(destination, _stream);
}
var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };
_fs.StorageClient.UploadObject(destination, _stream);
}
finally
{
Expand All @@ -163,14 +160,11 @@ public override async ValueTask DisposeAsync()
{
_stream.Position = 0;

if (_stream.Length != 0)
{
var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };
var destination = new global::Google.Apis.Storage.v1.Data.Object { Bucket = _fs.BucketName, Name = _objectName };

await _fs.StorageClient
.UploadObjectAsync(destination, _stream)
.ConfigureAwait(false);
}
await _fs.StorageClient
.UploadObjectAsync(destination, _stream)
.ConfigureAwait(false);
}
finally
{
Expand Down
Loading