Skip to content

Fix misspelling of stopPropagation#51

Merged
rameel merged 4 commits intomainfrom
fix-hotkey-plugin-typo
Apr 3, 2026
Merged

Fix misspelling of stopPropagation#51
rameel merged 4 commits intomainfrom
fix-hotkey-plugin-typo

Conversation

@rameel
Copy link
Copy Markdown
Owner

@rameel rameel commented Apr 2, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

📦 Bundle size comparison

Name Size Gzip Brotli Δ
alpinegear-when.min.js 1.22 KiB 657 B 570 B
alpinegear-when.esm.min.js 1.15 KiB 625 B 548 B
alpinegear-typegrab.min.js 509 B 348 B 294 B
alpinegear-typegrab.esm.min.js 471 B 333 B 277 B
alpinegear-template.min.js 480 B 323 B 246 B
alpinegear-template.esm.min.js 418 B 291 B 216 B
alpinegear-router.min.js 9.40 KiB 4.03 KiB 3.60 KiB
alpinegear-router.esm.min.js 9.38 KiB 4.01 KiB 3.58 KiB
alpinegear-match.min.js 1.49 KiB 778 B 681 B
alpinegear-match.esm.min.js 1.43 KiB 748 B 660 B
alpinegear-main.min.js 6.90 KiB 2.81 KiB 2.47 KiB
alpinegear-main.esm.min.js 6.93 KiB 2.86 KiB 2.52 KiB
alpinegear-hotkey.min.js 1.93 KiB 1.05 KiB 933 B (-5 B)
alpinegear-hotkey.esm.min.js 1.87 KiB 1.03 KiB 909 B (-19 B)
alpinegear-fragment.min.js 1.02 KiB 552 B 484 B
alpinegear-fragment.esm.min.js 980 B 521 B 457 B
alpinegear-format.min.js 1.10 KiB 638 B 554 B
alpinegear-format.esm.min.js 1.04 KiB 603 B 527 B
alpinegear-dialog.min.js 1.79 KiB 967 B 822 B
alpinegear-dialog.esm.min.js 1.75 KiB 951 B 811 B
alpinegear-destroy.min.js 191 B 167 B 123 B
alpinegear-destroy.esm.min.js 128 B 123 B 91 B
alpinegear-bound.min.js 3.93 KiB 1.81 KiB 1.57 KiB
alpinegear-bound.esm.min.js 3.88 KiB 1.79 KiB 1.55 KiB

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the .stop modifier implementation for x-hotkey by correcting the stopPropagation call, and adds Playwright coverage to prevent regressions.

Changes:

  • Correct e.stopPropagation() spelling in the hotkey plugin implementation.
  • Add a new Playwright spec covering core x-hotkey behaviors, including .stop propagation behavior.
  • Update the Playwright test harness page to load the hotkey plugin bundle.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/playwright/x-hotkey.spec.js Adds Playwright tests validating x-hotkey matching, modifiers, event payload, and cleanup.
tests/playwright/assets/page.html Loads the hotkey dist bundle so Playwright tests can exercise x-hotkey.
src/plugins/hotkey/index.js Fixes the misspelling and correctly invokes stopPropagation().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rameel rameel merged commit b9b0731 into main Apr 3, 2026
2 checks passed
@rameel rameel deleted the fix-hotkey-plugin-typo branch April 3, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants