Conversation
📦 Bundle size comparison
|
There was a problem hiding this comment.
Pull request overview
Fixes the .stop modifier implementation for x-hotkey by correcting the stopPropagation call, and adds Playwright coverage to prevent regressions.
Changes:
- Correct
e.stopPropagation()spelling in the hotkey plugin implementation. - Add a new Playwright spec covering core
x-hotkeybehaviors, including.stoppropagation behavior. - Update the Playwright test harness page to load the hotkey plugin bundle.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/playwright/x-hotkey.spec.js | Adds Playwright tests validating x-hotkey matching, modifiers, event payload, and cleanup. |
| tests/playwright/assets/page.html | Loads the hotkey dist bundle so Playwright tests can exercise x-hotkey. |
| src/plugins/hotkey/index.js | Fixes the misspelling and correctly invokes stopPropagation(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.