fix(deps): update dependency org.springframework.boot:spring-boot-starter-parent to v4 #1293

renovate · 2025-11-20T21:40:03Z

This PR contains the following updates:

Package	Change	Age	Confidence
org.springframework.boot:spring-boot-starter-parent (source)	`3.5.8` -> `4.0.0`

Release Notes

spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-parent)

`v4.0.0`

Compare Source

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

coderabbitai · 2025-11-20T21:40:10Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request modernizes the HTTP client configuration and test infrastructure. It replaces individual RestClient beans with a centralized RestClientHttpServiceGroupConfigurer, adds @HttpExchange annotations to service clients, updates PagedResult to use nullable wrapper types, refactors ProductController to manually parse JSON responses, and updates framework import paths and test dependencies.

Changes

Cohort / File(s)	Summary
HTTP Service Client Configuration `retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/ClientsConfig.java`, `retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/catalog/CatalogServiceClient.java`, `retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/customer/CustomerServiceClient.java`, `retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/inventory/InventoryServiceClient.java`, `retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/order/OrderServiceClient.java`	Replaced per-service RestClient bean creation with centralized RestClientHttpServiceGroupConfigurer in ClientsConfig, added `@ImportHttpServices` annotation to register all service clients. Added `@HttpExchange` base path annotations to each service client interface (/catalog-service, /payment-service, /inventory-service, /order-service).
Data Model Updates `retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/PagedResult.java`	Changed field types from primitives to nullable wrapper equivalents: totalElements (long → Long), pageNumber and totalPages (int → Integer), and boolean pagination flags (boolean → Boolean).
Controller & Service Integration `retail-store-webapp/src/main/java/com/example/retailstore/webapp/web/controller/ProductController.java`	Updated constructor to accept ObjectMapper alongside CatalogServiceClient. Modified getProducts to parse JSON string responses from catalog service client and reconstruct PagedResult objects.
Framework Imports & Annotations `retail-store-webapp/src/main/java/com/example/retailstore/webapp/config/WebConfig.java`, `retail-store-webapp/src/main/java/com/example/retailstore/webapp/exception/ResourceNotFoundException.java`	Replaced Spring `@NonNull` import with Jspecify `@NonNull` in WebConfig. Replaced String.format with String.formatted() in ResourceNotFoundException.
Application Configuration `retail-store-webapp/src/main/resources/application.properties`	Updated configuration keys: management.tracing.enabled → management.tracing.export.enabled; spring.http.client.* → spring.http.clients.*.
Test Infrastructure `retail-store-webapp/src/test/java/com/example/retailstore/webapp/common/AbstractIntegrationTest.java`, `retail-store-webapp/src/test/java/com/example/retailstore/webapp/common/ContainerConfig.java`	Replaced ObjectMapper with JsonMapper in AbstractIntegrationTest. Updated Keycloak container image from 26.4.2 to 26.4.7 in ContainerConfig.
Test Annotation & Import Updates `retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/InventoryControllerTest.java`, `LoginControllerTest.java`, `OrderControllerTest.java`, `ProductControllerTest.java`, `RegistrationControllerTest.java`	Updated WebMvcTest import path from org.springframework.boot.test.autoconfigure.web.servlet to org.springframework.boot.webmvc.test.autoconfigure. Replaced Jackson ObjectMapper import from com.fasterxml.jackson.databind to tools.jackson.databind.
Test Logic & Serialization Updates `retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/OrderControllerIT.java`, `ProductControllerIT.java`, `RegistrationControllerIT.java`	Replaced objectMapper with jsonMapper for JSON serialization across test mocks and assertions. Updated PagedResult constructor calls to reflect Long type for totalElements. Removed throws Exception declarations and updated exception types (JsonProcessingException → JacksonException).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

ProductController refactoring: Verify that manual JSON parsing via ObjectMapper correctly reconstructs PagedResult objects and that the service integration works as expected.
PagedResult type changes: Confirm that the shift from primitives to nullable wrapper types does not break existing serialization/deserialization or introduce unexpected null-handling issues.
HTTP client configuration migration: Ensure that the centralized RestClientHttpServiceGroupConfigurer correctly applies base URLs and headers to all service clients via @ImportHttpServices.
Test file import consolidation: While mostly repetitive, verify that the switch from com.fasterxml.jackson to tools.jackson and the WebMvcTest import path change work correctly across all test classes.

Possibly related PRs

feat : use OOTB http client settings #919: Modifies HTTP client configuration in ClientsConfig by removing timeout settings from RestClientCustomizer, related to the centralized group-configurer approach in this PR.
feat : create framework for integration Test #1089: Updates the same test scaffolding files (AbstractIntegrationTest and ContainerConfig), sharing code-level modifications for test infrastructure.
fix: update login link to redirect to /login instead of OAuth2 author… #1084: Modifies overlapping application classes (ProductController and ResourceNotFoundException), indicating related functional changes.

Poem

🐰 ✨ Hops through configs, neat and tight,
Service clients dance in grouped delight!
JSON strings now parsed with care,
Tests leap forward, imports spare—
A springtime refresh, oh what a sight!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: upgrading Spring Boot from v3 to v4, which is reflected across all modified files.
Description check	✅ Passed	The description clearly explains the dependency upgrade from Spring Boot 3.5.8 to 4.0.0, including release information and Renovate configuration details.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…rter-parent to v4

renovate · 2025-12-07T16:39:19Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

…ice proxy (parse JSON with ObjectMapper); update client to return raw JSON

…g product responses (disable FAIL_ON_NULL_FOR_PRIMITIVES for local mapper)

…rily when parsing products

…e safely via JsonNode to handle missing fields

…nstructing PagedResult in OrderControllerIT

rajadilipkolli · 2025-12-07T17:16:08Z

@coderabbitai, full review

coderabbitai · 2025-12-07T17:16:24Z

@rajadilipkolli, I'll conduct a full review of this Spring Boot 4.0.0 upgrade. This is a major version update that likely includes breaking changes, API updates, and new requirements. I'll analyze all the changes comprehensively.

✅ Actions performed

Full review triggered.

coderabbitai

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

retail-store-webapp/src/main/java/com/example/retailstore/webapp/web/controller/ProductController.java (1)

60-112: Manual JSON parsing defeats type-safe client design and creates maintainability burden.

This method performs 45+ lines of manual JSON tree parsing to reconstruct PagedResult<ProductResponse>, which:

Reimplements what Jackson would do automatically with proper deserialization
Is error-prone and harder to maintain (any DTO changes require updating this logic)
Loses compile-time type safety that typed responses provide
Has slower performance (tree model traversal vs. streaming deserialization)
Is inconsistent with other controllers: InventoryController (line 28) and OrderController (line 60) return typed PagedResult directly from their service clients without manual parsing

Recommendation: Revert CatalogServiceClient.getProducts() to return PagedResult<ProductResponse> instead of String, then simplify this method:

 PagedResult<ProductResponse> products(@RequestParam(defaultValue = "0") int page, Model model) {
     log.info("Fetching products for page: {}", page);
     try {
-        String json = catalogServiceClient.getProducts(page);
-        var root = objectMapper.readTree(json);
-        var dataNode = root.path("data");
-        var list = new ArrayList<ProductResponse>();
-        if (dataNode.isArray()) {
-            for (var elem : dataNode) {
-                Long id = elem.path("id").isNumber() ? elem.path("id").asLong() : null;
-                String productCode = elem.path("productCode").isMissingNode()
-                        ? null
-                        : elem.path("productCode").asText(null);
-                String productName = elem.path("productName").isMissingNode()
-                        ? null
-                        : elem.path("productName").asText(null);
-                String description = elem.path("description").isMissingNode()
-                        ? null
-                        : elem.path("description").asText(null);
-                String imageUrl = elem.path("imageUrl").isMissingNode()
-                                || elem.path("imageUrl").isNull()
-                        ? null
-                        : elem.path("imageUrl").asText(null);
-                double price = elem.has("price") && elem.path("price").isNumber()
-                        ? elem.path("price").asDouble(0.0)
-                        : 0.0;
-                boolean inStock =
-                        elem.has("inStock") && elem.path("inStock").isBoolean()
-                                ? elem.path("inStock").asBoolean(false)
-                                : false;
-                list.add(new ProductResponse(id, productCode, productName, description, imageUrl, price, inStock));
-            }
-        }
-
-        long totalElements = root.path("totalElements").isNumber()
-                ? root.path("totalElements").asLong()
-                : 0L;
-        int pageNumber =
-                root.path("pageNumber").isNumber() ? root.path("pageNumber").asInt() : 0;
-        int totalPages =
-                root.path("totalPages").isNumber() ? root.path("totalPages").asInt() : 0;
-        boolean isFirst = root.path("isFirst").asBoolean(false);
-        boolean isLast = root.path("isLast").asBoolean(false);
-        boolean hasNext = root.path("hasNext").asBoolean(false);
-        boolean hasPrevious = root.path("hasPrevious").asBoolean(false);
-
-        return new PagedResult<>(
-                list, totalElements, pageNumber, totalPages, isFirst, isLast, hasNext, hasPrevious);
+        return catalogServiceClient.getProducts(page);
     } catch (Exception e) {

This would also allow removing the ObjectMapper dependency from the constructor and the ArrayList import.

♻️ Duplicate comments (2)

retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/LoginControllerTest.java (1)

13-13: Verify the WebMvcTest import path.

This file has the same non-standard import path as OrderControllerTest.java. Please ensure all test files use the correct Spring Boot 4.0 import path once verified.

retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/InventoryControllerTest.java (1)

21-21: Verify import paths for Spring Boot 4.0.

This file contains the same non-standard import paths as other test files. Verification requested in OrderControllerTest.java applies here as well.

Also applies to: 27-27

🧹 Nitpick comments (2)

retail-store-webapp/src/main/resources/application.properties (1)
1-41: Add Swagger UI endpoint configuration per coding guidelines.

The coding guidelines require exposing Swagger UI endpoints at /swagger-ui.html for API documentation. While Line 11 correctly exposes all actuator endpoints, there is no explicit Swagger UI path configuration in this file.

If the application uses SpringDoc OpenAPI or similar Swagger UI libraries, add an explicit configuration entry to ensure the endpoint is properly exposed:
# Swagger UI endpoint configuration
springdoc.swagger-ui.path=/swagger-ui.html
If Swagger UI is auto-configured or configured elsewhere, ensure it remains accessible at /swagger-ui.html after the Spring Boot 4.0.0 upgrade.
retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/RegistrationControllerTest.java (1)
57-60: Optionally replace fully qualified customer DTO types with imports for readability

Lines 57–60 and 77–80 use fully qualified names (com.example.retailstore.webapp.clients.customer.CustomerRequest / CustomerResponse) instead of imports. To align with the project guideline of using imports rather than FQCNs, you could simplify these references:
@@
-import com.example.retailstore.webapp.clients.customer.CustomerServiceClient;
+import com.example.retailstore.webapp.clients.customer.CustomerServiceClient;
+import com.example.retailstore.webapp.clients.customer.CustomerRequest;
+import com.example.retailstore.webapp.clients.customer.CustomerResponse;
@@
-        when(customerServiceClient.getOrCreateCustomer(
-                        any(com.example.retailstore.webapp.clients.customer.CustomerRequest.class)))
-                .thenReturn(new com.example.retailstore.webapp.clients.customer.CustomerResponse(
+        when(customerServiceClient.getOrCreateCustomer(any(CustomerRequest.class)))
+                .thenReturn(new CustomerResponse(
                         1L, TEST_USERNAME, TEST_EMAIL, "9848022334", "junitAddress", 10_000));
@@
-        when(customerServiceClient.getOrCreateCustomer(
-                        any(com.example.retailstore.webapp.clients.customer.CustomerRequest.class)))
-                .thenReturn(new com.example.retailstore.webapp.clients.customer.CustomerResponse(
+        when(customerServiceClient.getOrCreateCustomer(any(CustomerRequest.class)))
+                .thenReturn(new CustomerResponse(
                         1L, TEST_USERNAME, TEST_EMAIL, "9848022334", "junitAddress", 0));
Also applies to: 77-80

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8482b28 and c4acc54.

⛔ Files ignored due to path filters (1)

retail-store-webapp/pom.xml is excluded by !**/*.xml

📒 Files selected for processing (20)

retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/ClientsConfig.java (1 hunks)
retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/PagedResult.java (1 hunks)
retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/catalog/CatalogServiceClient.java (1 hunks)
retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/customer/CustomerServiceClient.java (1 hunks)
retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/inventory/InventoryServiceClient.java (1 hunks)
retail-store-webapp/src/main/java/com/example/retailstore/webapp/clients/order/OrderServiceClient.java (1 hunks)
retail-store-webapp/src/main/java/com/example/retailstore/webapp/config/WebConfig.java (1 hunks)
retail-store-webapp/src/main/java/com/example/retailstore/webapp/exception/ResourceNotFoundException.java (1 hunks)
retail-store-webapp/src/main/java/com/example/retailstore/webapp/web/controller/ProductController.java (4 hunks)
retail-store-webapp/src/main/resources/application.properties (2 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/common/AbstractIntegrationTest.java (2 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/common/ContainerConfig.java (1 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/InventoryControllerTest.java (2 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/LoginControllerTest.java (1 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/OrderControllerIT.java (3 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/OrderControllerTest.java (1 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/ProductControllerIT.java (2 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/ProductControllerTest.java (3 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/RegistrationControllerIT.java (7 hunks)
retail-store-webapp/src/test/java/com/example/retailstore/webapp/web/controller/RegistrationControllerTest.java (1 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

**/*.java