Skip to content

Make disclaimer dialog scroll within a safe max height#353

Open
thedavidmeister wants to merge 2 commits into
mainfrom
2026-06-14-issue-18
Open

Make disclaimer dialog scroll within a safe max height#353
thedavidmeister wants to merge 2 commits into
mainfrom
2026-06-14-issue-18

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

What

On some screen sizes the disclaimer modal filled the whole screen and its content overflowed without any way to scroll (issue #18).

DialogContent had max-h-[80vh] but no overflow-y, so when the content was taller than the cap it spilled out instead of scrolling.

This swaps the height cap to max-h-screen-safe (the safe inside height from the tailwindcss-safe-area plugin the issue author added for exactly this) and adds overflow-y-auto, so tall disclaimer content scrolls within the dialog. CSS-only, no behavioral change to the dialog otherwise.

-				'max-h-[80vh] fixed left-[50%] top-[50%] ...
+				'max-h-screen-safe overflow-y-auto fixed left-[50%] top-[50%] ...

The max-h-screen-safe utility compiles to:
max-height: calc(100vh - (env(safe-area-inset-top) + env(safe-area-inset-bottom)))

Verification

  • npm run build green
  • npm run lint-check green (only pre-existing unused-eslint-disable warnings, none in the changed file)

Closes #18

DialogContent caps its height at the safe inside height and scrolls its
own overflow, so tall disclaimer content stays within the dialog.

Closes #18

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Jun 14, 2026
@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
rain-frame Ready Ready Preview, Comment Jun 19, 2026 5:25pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thedavidmeister, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 45 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b899427a-0905-4ab2-b182-fc59a0c394cc

📥 Commits

Reviewing files that changed from the base of the PR and between 7c7f5b3 and 75a419a.

📒 Files selected for processing (1)
  • components/ui/dialog.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-06-14-issue-18

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister

Copy link
Copy Markdown
Contributor Author

Screenshot after the fix: the disclaimer dialog is capped at the safe inside height and scrolls its own overflow, so tall content stays within the dialog instead of overflowing the screen. (Rendered from the dialog markup with the changed max-h-screen-safe overflow-y-auto classes.)

@thedavidmeister

Copy link
Copy Markdown
Contributor Author

screenshot

UI screenshot: disclaimer dialog now scrolls within a safe max height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disclaimer height issue

1 participant