Repository navigation
fix(geom3d): accept array-like volume bounds - #274
Open
Doribelove wants to merge 1 commit into
Open
Doribelove wants to merge 1 commit into
Doribelove wants to merge 1 commit into
Conversation
Signed-off-by: 李永祺 <doribelove@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line3.intersect_volume()documents six array-like bounds, but passing a Python list or tuple raisesAttributeErroratbounds.reshape(...). Row and column NumPy vectors also fail later because the face loop indexes the unflattened bounds.Normalize the bounds once with
base.getvector(bounds, 6), asLine3.plot()already does. This accepts lists, tuples, flat arrays, and row/column vectors, and validates their length before the face loop. Correct the bounds type field and the reshape comment. The intersection algorithm and return structure are unchanged.Add 21 regression cases for axis-aligned and oblique intersections, a line outside the volume, all five input formats, and invalid lengths. Check intersection coordinates, point-array shape and line parameters.
Validation against upstream
41e0a4d:git diff --checkpass.