Repository navigation
PrintVect 0.5.10: a changed host key says so; Trust it again; hellos checked - #25
Merged
Merged
Conversation
…checked The owner's follow-ups after 0.5.9: - MovedHostVerdict tells "did not answer" (Unreachable) from "proved a different key with a valid signature for this address" (KeyChanged, NewKeyId) and from "no proof". TcpJobSender throws HostIdentityException for the last two; when the PC-name try after it leads nowhere better, the identity reason is rethrown instead of the name's "did not answer". ClientService searches once, then keeps the job for Retry with that reason as its message (no more tries). - Trust it again (Printers on other PCs): a printer whose host proved a different key shows "Identity changed" and the button in place of Test page. It checks the PC again and, after the person confirms (No is the default; a warning when the PC gives another name), takes the new key for every printer of that PC. - Hellos pass the same EnsureHostAsync check as jobs and are skipped when it fails; key learning for older printers happens there, so the hello reply event and LearnHostKey are gone. - Settings and Diagnostics warn about a digits-only sharing PIN. - Fixes: SharingDialog comment (8 to 12), PinDialog summaries in the right place, README "/pin <the sharing PIN>". - docs/testing.md: 0.5.9 step 2 states what 0.5.9 really shows; new 0.5.10 section with the reinstall-HOST steps. - Tests: changed key keeps its reason after the name fallback, job message after one search, hello only to a proven PC, verdict kinds. - Version 0.5.10; protocol.md, SECURITY.md, README, CLAUDE.md, CHANGELOG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFV1W7wPfiMU9itafQutsk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner's five follow-ups after 0.5.9.
Changes
TcpJobSenderthrows the newHostIdentityExceptioninstead ofHostUnreachableException.ClientServicesearches once for the host elsewhere. If it isn't found, the job waits for Retry with that reason as its message and is not tried again.EnsureHostAsynccheck as jobs and is skipped if the check fails. Older printers now learn their host's key through that check, soLearnHostKeyand the hello-answered event are removed.SharingDialogcomment now says 8 to 12.PinDialogsummaries are back on the right methods./pin <the sharing PIN>.Version 0.5.10. Also updated:
protocol.md,SECURITY.md,README.md,CLAUDE.mdandCHANGELOG.md.Checked
Generated by Claude Code