Repository navigation
Add type hints to modularitypruning - #14
Merged
Merged
Conversation
Used `righttyper run --root utilities -m pytest -- -m "not serial" tests/` Current package version pulled from GitHub (a18f2b0 from Sep 9 2026) since pip is greatly outdated
[X] __init__.py [X] champ_utilities.py [X] leiden_utilities.py [X] louvain_utilities.py [X] parameter_estimation.py [X] parameter_estimation_utilities.py [X] partition_utilities.py [X] plotting.py
Also remove all use of Any in type hints
Drop Python 3.9 testing for newer typing features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #8 and makes the package much more robust by allowing mypy (or other static analysis tools) to catch bugs automatically.
I've also added a few additional guards and removed the long-deprecated Louvain and Progress parts of the package, which will require a bump to the major version number. The Louvain functions still automatically shim to Leiden as before.
I've heavily rebased the commit history here to make it more intelligible.