fix(symbolizer): Introduce per-process module maps#556
Merged
rabbitstack merged 1 commit intomasterfrom Jan 27, 2026
Merged
Conversation
rabbitstack
force-pushed
the
symbolizer-cached-modules-per-process
branch
2 times, most recently
from
30b6c3f to
244a319
Compare
Having multiple processes share the same module maps is a call for chaos. For this reason, each process now has its distinct map and the export directory contains cached export entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Previously, symbolizer had a cache of all modules involved in call stack frames. The map of modules was designed by indexing the module path to module info. This could lead to bogus symbolization outcomes if the module is unloaded on the base address that is later recycled to load a new module.
To mitigate this problem, the symbolizer holds a per-process module map.
What type of change does this PR introduce?
/kind bug-fix (non-breaking change which fixes an issue)
Any specific area of the project related to this PR?
/area telemetry
Special notes for the reviewer
Does this PR introduce a user-facing change?