perf(rule-engine, eventsource): Implement more efficient event bitsets#515
Merged
rabbitstack merged 4 commits intomasterfrom Jun 9, 2025
Merged
perf(rule-engine, eventsource): Implement more efficient event bitsets#515rabbitstack merged 4 commits intomasterfrom
rabbitstack merged 4 commits intomasterfrom
Conversation
f08ea35 to
d29ef90
Compare
The new bitmask implementation is introduced to deal with event id bits testing.
55c5acd to
a680bc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
For testing if the specific event bit is set, we use the map-backed bitmask. The event identifiers are expressed as an unsigned 64-bit integer. The collection of multiple bitsets permits checking whether the event type, event ID, or category bits are set. As an additional improvement, all known event IDs are put inside the mask and checked at the very early stage of event processing, dropping all uninterested or unknown event types and preventing unnecessary memory allocations.
What type of change does this PR introduce?
/kind cleanup
/kind improvement
Any specific area of the project related to this PR?
/area telemetry
/area rule-engine
Special notes for the reviewer
Does this PR introduce a user-facing change?