Set dll exports #473
Merged
Set dll exports #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! Indeed I think this is kind of redundant because the of the way windows resolves symbols but I guess it does not do any harm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows 1ffdce4; inspired by the analogous change in Rdatatable/data.table#7607.
https://cran.r-project.org/doc/manuals/r-devel/R-exts.html#Creating-shared-objects-1
See also Ivan's comment: Rdatatable/data.table#7607 (comment) -- it's not clear it's a problem to omit this file, but it does seem to follow the intent of the .so symbol exposure.