Fix windows filenames#141
Open
jeroen wants to merge 2 commits into
Open
Conversation
packages_make_target() built the download/cache target from the File field first, and only fell back to Path when File was NA. This meant that PACKAGES entries with both fields set had Path silently dropped instead of combined, producing repodir/file instead of the correct repodir/path/file. Handle all four combinations explicitly: both present, only File, only Path, and neither. See r-universe-org/help#715
jeroen
force-pushed
the
fix-windows-filenames
branch
from
374b14b to
04a90b5
Compare
jeroen
force-pushed
the
fix-windows-filenames
branch
from
04a90b5 to
19a5635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
PathandFileare set, they must be combined.PathorFilecontains a query string, we strip it when determining the local filename.