Skip to content

Conversation

@kndehaan
Copy link
Contributor

@kndehaan kndehaan commented Dec 30, 2025

Description

This PR:

  • adds queries for the biomass sankey for industry transformation flows
  • removes old biomass sankey queries including the mechanical turk queries

Goes with quintel/etmodel#4620

Type of change

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

Related Issues

Closes #

@kndehaan kndehaan changed the base branch from master to biomass-sankey December 30, 2025 16:03
@kndehaan kndehaan marked this pull request as draft December 30, 2025 16:03
@kndehaan kndehaan marked this pull request as ready for review January 5, 2026 09:15
@kndehaan kndehaan force-pushed the biomass-sankey-industry-transformation branch from d368e49 to b016ce8 Compare January 5, 2026 09:49
@kndehaan kndehaan force-pushed the biomass-sankey-industry-transformation branch from b016ce8 to cefb2a5 Compare January 5, 2026 10:22
@kndehaan kndehaan mentioned this pull request Jan 5, 2026
7 tasks
@kaskranenburgQ
Copy link
Contributor

LGTM!
One remark is that the flow from green gas to industry transformation is now modeled from the greengas in column 1 to column 2.
This can lead to an imbalance on the greengas node of column 3 (greengas_secondary) when there is greengas demand for industry transformation. This is because the biogas and greengas flows that are used for industry transformation demand are flowing through the greengas secondary node.

This can be seen in the screenshot below:
Uploading Screenshot 2026-01-05 at 16.15.23.png…

However I don't see a better way to model this, therefore:
We should notify the client about this, and take this into account while adding the mechanical turk specs.

Copy link
Contributor

@kaskranenburgQ kaskranenburgQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kndehaan
Copy link
Contributor Author

kndehaan commented Jan 5, 2026

However I don't see a better way to model this, therefore:
We should notify the client about this, and take this into account while adding the mechanical turk specs.

Good point. I also don't see a better option to solve this. I think that's one of the flaws when using the expert feature (external coupling), where we allow imbalance.

@kndehaan kndehaan merged commit 8284b5c into biomass-sankey Jan 5, 2026
1 check passed
@kndehaan kndehaan deleted the biomass-sankey-industry-transformation branch January 5, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants