Households insulation chart - #4796
Open
jort-wolda wants to merge 3 commits into
Open
Conversation
Charts with a "serie_selections" config now render the same dropdown as the solar_curtailment_curve chart, filtering the drawn series by gquery key so the selection stays independent of the grouping into categories. Changing the selection redraws the chart in full, since both the categories and the bar geometry depend on which series are visible. The dropdown stays visible on an empty chart, so a selection with no data is not a dead end.
- Added the new chart that shows heat demand per building - Made som changes to the chart that shows total heat demand
- Changed the label name from 'Total' to 'All construction periods' - Deleted the old lines for the total bar
3 tasks
jort-wolda
marked this pull request as ready for review
August 27, 2026 09:37
mabijkerk
changed the title
Contributor
|
Review:
|
Member
|
@robindesmit-quintel thanks for the review notes. As Jort's work in this PR is only related to adding new user output (charts), I think it's not needed to put too much effort in improving (existing) slider texts within this PR. I'd suggest to only pick up the following from Robin's review comments:
|
kndehaan
reviewed
Aug 28, 2026
kndehaan
reviewed
Aug 28, 2026
Member
There was a problem hiding this comment.
@aaccensi do you understand why there's a different order of the legend labels compared to the series in the chart? Do order of the chart is logical (newly built at the top, oldest at bottom). The label order seems quite random though.
kndehaan
reviewed
Aug 28, 2026
Comment on lines
+497
to
+499
| title: Residential space heating demand per house | ||
| description: | | ||
| This bar chart shows the useful demand for space heating per house, per building period and residence type. |
Member
There was a problem hiding this comment.
- Could you change the title to ".. per residence".
- The "..per house, ... residence type" seems somewhat double.
- Could you rename "building period" to "construction period"
kndehaan
reviewed
Aug 28, 2026
| position: 105 | ||
| sidebar_item_key: households | ||
| output_element_key: residential_heating_demand | ||
| output_element_key: residential_heating_demand_per_house |
Member
There was a problem hiding this comment.
Could you rename the output_element_key to ...per_residence ?
kndehaan
reviewed
Aug 28, 2026
| '1945_1964': "1945 - 1964" | ||
| '1965_1984': "1965 - 1984" | ||
| '1985_2004': "1985 - 2004" | ||
| '2005_present': "2005 - present" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The etsource changes for the charts for the households - insulation section.
Implemented changes
Related
Goes with pull requests:
Checklist