Interpolate between two scenarios #1685
Open
+1,142
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaccensi
force-pushed
the
scenario-interpolation
branch
from
8fe07d1 to
654db5d
Compare
noracato
reviewed
Dec 19, 2025
Member
noracato
left a comment
noracato
left a comment
There was a problem hiding this comment.
Nice work! Especially on the specs! Thank you for adding the extra spec for the API as well.
It works well as an extension of the existing code. I do think we can win some space by replacing the now many validators by introducing simple Dry validation rules. @louispt1 has been working with them a lot lately, he should be able to help you out.
Again well done!
louispt1
requested changes
Dec 29, 2025
Contributor
louispt1
left a comment
louispt1
left a comment
There was a problem hiding this comment.
Apart from the one remark below and the spec for the batch endpoint I'd say it's looking good!
…dpoint specs. References #1684
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the capability to interpolate between two scenarios with the API endpoint:
POST /api/v3/scenarios/interpolateNow if we pass a
start_scenario_idbesides the mandatoryend_yearit will interpolate using the values of the given start scenario instead of the starting values of the scenario targeted by the endpoint.Type of change
Checklist
Related Issues
Closes #1684