Faster byte range cache - #6683
Open
PSeitz wants to merge 4 commits into
Open
Conversation
Partition cached ranges by path using an FxHashMap so range lookups only compare integer offsets within the selected file.
Resolve each path's cache when opening a file so range reads avoid repeated path lookups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize byte range cache lookups.
In regex queries we have a lot of
FileHandle::read_byteslookups, which are passed toNeedMutByteRangeCache::get_slice. The path comparison was very expensive in these cases, although a lookup will never cross path boundaries.This PR removes the repeated path lookups by moving it to one layer above to the
FileHandle