Merged
Conversation
5 tasks
mattmkim
force-pushed
the
matthew.kim/metrics-wide-schema
branch
3 times, most recently
from
7621e22 to
1b50f21
Compare
mattmkim
force-pushed
the
matthew.kim/metrics-wide-schema
branch
from
1b50f21 to
0b642de
Compare
mattmkim
force-pushed
the
matthew.kim/metrics-wide-schema
branch
from
0b642de to
7a5979f
Compare
fulmicoton-dd
approved these changes
Mar 31, 2026
Collaborator
|
@mattmkim I only reviewed the changes in the global scope. Can you complete the review? |
g-talbot
force-pushed
the
gtt/phase-31-sort-schema
branch
5 times, most recently
from
366dd33 to
a64ddaf
Compare
g-talbot
force-pushed
the
gtt/phase-31-sort-schema
branch
3 times, most recently
from
8fce718 to
018a265
Compare
5 tasks
g-talbot
force-pushed
the
gtt/phase-31-sort-schema
branch
from
018a265 to
3696bb4
Compare
g-talbot
force-pushed
the
gtt/phase-31-sort-schema
branch
4 times, most recently
from
cf9484d to
bb42b42
Compare
…, window, TableConfig Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
g-talbot
force-pushed
the
gtt/phase-31-sort-schema
branch
from
bb42b42 to
5b2304c
Compare
g-talbot
force-pushed
the
gtt/phase-31-sort-schema
branch
from
39f875f to
4d42fd9
Compare
mattmkim
approved these changes
Apr 6, 2026
Contributor
mattmkim
left a comment
mattmkim
left a comment
There was a problem hiding this comment.
LGTM - just a few Qs for myself, 1 small change since we've removed the tag_ prefix from tag columns
Co-authored-by: Matthew Kim <matthew.kim@datadoghq.com>
Co-authored-by: Matthew Kim <matthew.kim@datadoghq.com>
Resolve merge conflicts by taking main's versions of otel_metrics.rs and arrow_metrics.rs (the PR didn't modify these files — conflicts came from the base branch divergence). Kept PR's table_config module export in quickwit-parquet-engine/src/lib.rs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sort schema types, parsing, and time-window arithmetic for metrics compaction (Phase 31 Metadata Foundation, PR 1 of 4).
Stacks on
matthew.kim/metrics-wide-schema.What's included
quickwit-proto:
event_store_sortschema.proto(SortSchema, SortColumn, RowKeys, ColumnValue types)SortFieldsErrorerror type for parser/validation errorsFrom<SortFieldsError>impl forMetastoreErrorquickwit-parquet-engine:
sort_fields/module:column_type.rs— ColumnTypeId enum matching Go iota values, suffix/name resolutionparser.rs— Direct port of GoStringToSchemawith V2-only enforcementdisplay.rs—schema_to_string/schema_to_string_short(port of GoSchemaToString)equivalence.rs— Schema comparison for compaction (port of GoEquivalentSchemas)validation.rs— Schema validation rules (port of GoValidateSchema)window.rs—window_start()withrem_euclidfor negative timestamp correctness,validate_window_duration()with hour-divisibility constrainttests.rs— 97 tests including Go test port, proptests for window invariantstable_config.rs—TableConfigwith per-product-type default sort fields, serde supportVerification
cargo build -p quickwit-parquet-engine✅cargo test -p quickwit-parquet-engine -- sort_fields table_config✅ (97 tests)cargo clippy -p quickwit-parquet-engine --all-features --tests✅ (no new warnings)Test plan
🤖 Generated with Claude Code