Prevent Object.preventExtensions when a TypedArray has a resizable ArrayBuffer - #1695
Open
sr5434 wants to merge 1 commit into
Open
Prevent Object.preventExtensions when a TypedArray has a resizable ArrayBuffer#1695sr5434 wants to merge 1 commit into
sr5434 wants to merge 1 commit into
Conversation
sr5434
force-pushed
the
throw_error_prevent_extensions
branch
from
August 25, 2026 14:37
53741f3 to
23aecdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1691 by checking if the TypedArray's underlying ArrayBuffer is resizable, and throws an error if so. I also edited the error message when JS_PreventExtensions is false to be "Cannot prevent extensions", as this is more applicable to the widened set of reasons why the function might return false. Finally, I added a regression test.