Skip to content

perf(dtoa,quickjs): speed up string<->number conversions #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzjjob wants to merge 8 commits into
base: master
Choose a base branch
from
Open

perf(dtoa,quickjs): speed up string<->number conversions #1664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8604e88
perf(dtoa): fast path for plain decimal string to double
zzjjob Aug 24, 2026
3389db9
perf(dtoa): Ryu shortest representation for free-format doubles
zzjjob Aug 24, 2026
5869f43
perf(quickjs): fast StringToNumber path for plain decimal strings
zzjjob Aug 24, 2026
ebd7125
perf(quickjs): single-scan StringToNumber via dtoa fast parser
zzjjob Aug 24, 2026
b6de8c8
fix(dtoa): undefined behavior when the 64-bit division quotient is zero
zzjjob Aug 24, 2026
cc8ba8a
fix(dtoa): guard fast-parser declarations like their definitions
zzjjob Aug 24, 2026
7c552da
fix(dtoa): disable the string fast path for MSVC-target clang
zzjjob Aug 24, 2026
66344c5
refactor(dtoa): address review feedback
zzjjob Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,10 @@ add_executable(unicode_gen EXCLUDE_FROM_ALL
)
target_compile_definitions(unicode_gen PRIVATE ${qjs_defines})

add_executable(ryu_gen EXCLUDE_FROM_ALL
ryu_gen.c
)

add_executable(function_source
gen/function_source.c
)
Expand Down
8 changes: 7 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,10 @@ unicode_gen: $(BUILD_DIR)
libunicode-table.h: unicode_gen
$(BUILD_DIR)/unicode_gen unicode $@

.PHONY: all amalgam ctest cxxtest debug fuzz jscheck install clean codegen distclean stats test test262 test262-update test262-check microbench unicode_gen $(QJS) $(QJSC)
ryu_gen: $(BUILD_DIR)
cmake --build $(BUILD_DIR) --target ryu_gen

dtoa-ryu-table.h: ryu_gen
$(BUILD_DIR)/ryu_gen $@

.PHONY: all amalgam ctest cxxtest debug fuzz jscheck install clean codegen distclean stats test test262 test262-update test262-check microbench unicode_gen ryu_gen $(QJS) $(QJSC)
2 changes: 2 additions & 0 deletions amalgam.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {loadFile, writeFile} from "qjs:std"
const cutils_h = loadFile("cutils.h")
const dtoa_c = loadFile("dtoa.c")
const dtoa_h = loadFile("dtoa.h")
const dtoa_ryu_table_h = loadFile("dtoa-ryu-table.h")
const libregexp_c = loadFile("libregexp.c")
const libregexp_h = loadFile("libregexp.h")
const libregexp_opcode_h = loadFile("libregexp-opcode.h")
Expand Down Expand Up @@ -43,6 +44,7 @@ let source = "#if defined(QJS_BUILD_LIBC) && defined(__linux__) && !defined(_GNU
source = source.replace(/#include "quickjs-atom.h"/g, quickjs_atom_h)
source = source.replace(/#include "quickjs-opcode.h"/g, quickjs_opcode_h)
source = source.replace(/#include "libregexp-opcode.h"/g, libregexp_opcode_h)
source = source.replace(/#include "dtoa-ryu-table.h"/g, dtoa_ryu_table_h)
source = source.replace(/#include "builtin-array-fromasync.h"/g,
gen_builtin_array_fromasync_h)
source = source.replace(/#include "builtin-iterator-zip.h"/g,
Expand Down
363 changes: 363 additions & 0 deletions dtoa-ryu-table.h
View file
Open in desktop

Large diffs are not rendered by default.

Loading