Replace deprecated ExecType values in Executor application - #1296
Open
chrjohn wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## copilot/remove-full-minimal-fix-distinction #1296 +/- ##
==============================================================================
Coverage ? 70.36%
Complexity ? 2242
==============================================================================
Files ? 159
Lines ? 9056
Branches ? 1192
==============================================================================
Hits ? 6372
Misses ? 2220
Partials ? 464 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Values 1 and 2 are deprecated since FIX4.4.
chrjohn
force-pushed
the
chrjohn-deprecated-exectype-values
branch
from
August 3, 2026 11:14
d57e32f to
74b6529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExecTypevalues1/PARTIAL_FILLand2/FILLare deprecated since FIX4.4.When switching to the
full-fix-latestprofile, these values will be gone.So for the Executor application we need to pass these values as literal value since the
quickfix.fieldpackage only contains the fields and values from the most recent FIX version (i.e. FIXLatest). In prior QFJ versions this behaviour was different since the FIX dictionaries (from which the field classes were generated) were manually changed to still containExecTypevalues 1 and 2. Example:quickfixj/quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.modified.xml
Lines 5984 to 5989 in b2c94dd