Repository navigation
Conversation
Traverse nested component references while preserving direct group handling. Add regression coverage for quickfix-j/quickfixj#822. Remove trailing whitespace from generated message factories and update the FIX42 and FIX44 golden files.
Member
|
Hey @6democratickim9 , thanks for the PR. 👍 |
chrjohn
requested changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessageFactory generation skips groups reached through a component nested inside another component. In QuickFIX/J #34, creating group 457 for a FIX50SP2 TradeCaptureReport consequently returns null.
Traverse both group and component children when resolving component references, preserving the enclosing Java group path. Add a small dictionary and regression test covering the outer group and nested group factory entry.
Also strip trailing whitespace from generated MessageFactory sources and update the FIX42/FIX44 golden files. Ignoring end-of-line whitespace, FIX42 is unchanged and FIX44 gains 59 previously missing NoUnderlyingStips factory branches; existing branches are retained.
Validation on macOS with JDK 17:
./mvnw clean install -B -V -Dmaven.javadoc.skip=true -Dgpg.skip=true: all 8 tests passed after the final changes.git show --format= --check HEAD: passed.Related to #34. QuickFIX/J will need to adopt a generator release containing this fix.