fix: follow the landing-page base-path rename to /codev#207
Merged
Conversation
The landing page now serves under /codev instead of /codev-landing-page, so point LOGIN_SUCCESS_URL at the new OAuth-relay path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CoDev landing page is moving from the
/codev-landing-pagesub-path to/codev(see codev-landing-page#35). This updates the one place CoDev Hub hard-codes that path —LOGIN_SUCCESS_URL, the OAuth-relay redirect target.src/lib/const.ts:${BASE_URL}/codev-landing-page/oauth/success→${BASE_URL}/codev/oauth/successCoordination
This must ship together with the landing-page base-path change and the reverse-proxy route update — otherwise the OAuth success redirect will 404. The tests reference
LOGIN_SUCCESS_URLsymbolically, so they track the new value automatically.Test plan
pnpm typecheck— cleanpnpm test— 944 passing (incl. the 66 auth tests that exerciseLOGIN_SUCCESS_URL)pnpm build— succeeds🤖 Generated with Claude Code