Repository navigation
Fix global annotations ignored when the class path contains a plus sign - #291
Merged
jeanbisutti merged 1 commit intoOct 20, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuickPerf finds the class implementing
SpecifiableGlobalAnnotations, and the one implementingSpecifiableSqlFormatter, by scanning theorg/quickperfdirectories of the class path (QuickPerfUserConfigClasses). It converted each directory URL to a file path withURLDecoder.decode(resource.getPath(), "UTF-8").URLDecoderdecodes HTML form data, where+stands for a space, but in a URL path a space is written%20and+is a plus sign.So when the URL of a class path directory contained a
+, the decoded path did not exist. For example,C:\work\my+project\target\test-classesbecameC:\work\my project\target\test-classes, and/home/dev/R+D/app/build/classes/java/testbecame/home/dev/R D/app/build/classes/java/test. A folder namedC++has the same problem. QuickPerf skipped the directory without any message: the global annotations were not applied, and a user SQL formatter was not used.This PR encodes
+as%2Bbefore decoding, so that a+in the URL decodes to+. An encoded%2Bor%20decodes as before.