Skip to content

Fix flaky SameSelectsTest and SameSelectTypesWithDiffParamValuesTest - #287

Merged
jeanbisutti merged 1 commit into
quick-perf:masterfrom
jeanbisutti:fix-flaky-same-select-tests
Oct 17, 2026
Merged

jeanbisutti merged 1 commit into
quick-perf:masterfrom
jeanbisutti:fix-flaky-same-select-tests

Conversation

@jeanbisutti

Copy link
Copy Markdown
Collaborator

SameSelectTypesWithDiffParamValuesTest failed on the Java 8 CI job of #285 with an error that PR does not cause:

SameSelectTypesWithDiffParamValuesTest.should_return_false_with_same_selects_without_params:64
  » java.util.ConcurrentModificationException

SameSelectsTest and SameSelectTypesWithDiffParamValuesTest both added their test data to the shared constant SqlExecutions.NONE:

SqlExecutions sqlExecutions = SqlExecutions.NONE;
sqlExecutions.add(execInfo, asList(queryInfo1, queryInfo2));

@jeanbisutti
jeanbisutti merged commit 8ea3ab6 into quick-perf:master Oct 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant