Skip to content

test(qwp): fix flaky SenderErrorDispatcher overflow test #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bluestreak01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(qwp): fix flaky SenderErrorDispatcher overflow test #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions ...t/java/io/questdb/client/test/cutlass/qwp/client/sf/cursor/SenderErrorDispatcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,12 @@ public void testFullInboxDropsOldestAndCounts() throws Exception {
// and admit the new one. The latest entry is always the most
// informative, so the FIFO head loses, not the new arrival.
CountDownLatch unblock = new CountDownLatch(1);
CountDownLatch handlerEntered = new CountDownLatch(1);
List<SenderError> received = new ArrayList<>();
Object lock = new Object();
CountDownLatch allDelivered = new CountDownLatch(5);
try (SenderErrorDispatcher d = new SenderErrorDispatcher(err -> {
handlerEntered.countDown();
try {
unblock.await();
} catch (InterruptedException ignored) {
Expand All @@ -116,13 +118,15 @@ public void testFullInboxDropsOldestAndCounts() throws Exception {
}
allDelivered.countDown();
}, /*capacity=*/ 4)) {
// First offer starts the dispatcher and lands in the handler
// immediately (and blocks there). Now we can fill the bounded
// inbox to capacity, then overflow.
// The first offer lazily starts the dispatcher thread, which
// takes the head into the handler and blocks there. Wait for
// that handoff: once the handler has entered, error 0 is out
// of the inbox, so the fill below starts from an empty queue.
// A fixed sleep here raced the lazy thread start on loaded CI
// agents and produced a third drop (expected 2, got 3).
Assert.assertTrue(d.offer(buildError(0)));
// Give the dispatcher a moment to take the head into the
// handler so subsequent offers don't get an extra slot.
TimeUnit.MILLISECONDS.sleep(50);
Assert.assertTrue("handler should take the head within 5s",
handlerEntered.await(5, TimeUnit.SECONDS));
for (int i = 1; i <= 4; i++) {
Assert.assertTrue("inbox should accept offer " + i,
d.offer(buildError(i)));
Expand Down
Loading