Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
kv9898
marked this pull request as ready for review
September 26, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching back to Positron from another application can move the visual editor's caret to the start of a code chunk. During focus restoration, focusing the outer ProseMirror editor can clear the browser selection before CodeMirror regains focus; CodeMirror then reads that DOM selection and resets its cursor.
Allow an extension to handle focus before the outer editor. When a text selection is wholly inside a CodeMirror chunk, restore that selection and focus CodeMirror directly. Other selections retain the existing focus path. The restoration delay and the separate editor-tab focus behavior are unchanged.
References #340 and posit-dev/positron#4248.
Validation:
Run the browser fixture from the repository root:
Open the printed local URL at
/focus.html. No new dependencies are required. The fixture verifies restoration and routing; it does not reproduce the complete native application-switch failure on the original path. That failure and the final fix were verified manually in Positron.