Skip to content

apps/lsp build copies nonexistent ./src/run.js #1140

Description

@nealrichardson

Bug

apps/lsp/build.ts:20 lists an asset that doesn't exist:

{ from: ['./src/run.js'], to: '../vscode/out/lsp' },

apps/lsp/src/run.js isn't in the repo, and nothing else references run.js. esbuild-plugin-copy silently copies nothing for an unmatched glob, so the build still succeeds. It's dead config, left over from an earlier layout.

Fix

Delete that line. Then confirm that yarn build-vscode still produces apps/vscode/out/lsp/lsp.js and that the extension starts the language server (serverModule in apps/vscode/src/lsp/client.ts points at lsp.js, not run.js).

Low priority, but it's misleading when you're reading the build, and it'll cause a warning or error if the copy plugin ever gets stricter about unmatched globs (relevant to the esbuild upgrade).

Found during the dependency-upgrade research.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions