Repository navigation
Report runtime boundary increases a PR has already accepted as notices - #15183
Merged
Merged
Conversation
In pull request mode the check compared the merge result only with the base branch, so a PR that had already run --update-baseline --accept-increase still got one warning per new call and the "Maintainer action before merging" block (seen on PR 15180, which raised tests from 832 to 838). Reviewers could not tell whether the step was still pending. The check now also reads the working tree's baseline. A count the PR raised there and does not exceed is reported as a notice plus an "Accepted in this PR" line; that is the state the push check on main will see after merge. Slack already present in the base baseline does not count as acceptance, so new calls still get a warning unless the PR raises the number itself. A baseline raised before updating from main, and now too low, keeps the warnings. Errors for APIs that src/deno_ral replaces are unchanged.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15153.
In pull request mode the runtime boundary check compares the merge commit with the base branch only, so it never sees the PR's own
tools/runtime-boundary-baseline.json.#15180 ran the maintainer step (
--update-baseline --accept-increase,tests832 → 838) and the check still reported the six new calls as warnings saying "a maintainer accepts the new count before merging", with the "Maintainer action before merging" block in the job summary (run).A reviewer cannot tell from the check whether the step is done.
Fix
PR mode now also reads the baseline in the merge commit.
When the PR raised a count there and the merge result does not exceed it, each finding for that count is a notice ("accepted by this PR's
tools/runtime-boundary-baseline.json") on the added line, and the summary lists it under "Accepted in this PR" with the old and new baseline value.This is the comparison the push check on
mainmakes after merge.A count is accepted only when the PR raised it.
Room left in
main's baseline (a count below its baseline because nobody lowered it) does not hide a new call: it stays a warning.A baseline raised before updating the branch with
main, and now too low for the merge result, also keeps the warnings and the maintainer block.Errors for a
Deno.*API thatsrc/deno_ralreplaces do not depend on the baseline and are unchanged.The new test runs the script with
quarto run --dev ... --against HEADin a temporary git repo, like CI does: before the fix it showed the same warning and maintainer block as #15180.Checklist
I have (if applicable):
AI-assisted PR
Note: autonomous AI agents submitting PRs without human oversight are not permitted — see the Code of Conduct.