Repository navigation
revealjs: improve speaker view labels and landmark navigation - #15164
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cderv
left a comment
There was a problem hiding this comment.
Thanks for this, and for opening the upstream PR first.
I checked the rebuilt files against reveal.js 5.1.0 with the four patches applied. speaker-view.html matches the patched source, the notes bundles embed it as is, and the core bundles and source maps only change the controls aside to a div. The new speaker view tests pass for me locally in Chromium, Firefox and WebKit, and they fail on the current reveal.js files.
We'll push a small adjustment on your branch before merging, so no need to push anything meanwhile. It moves the changelog entry to its place by issue number, and makes the layout test compare the full slide indices: the first slide has a fragment, so with the key forwarding back, ArrowDown reveals the fragment and the horizontal index alone stays at 0.
The layout test checked only the horizontal slide index after pressing ArrowDown on the Layout select. The fixture's first slide has a fragment, so when the speaker view forwards the key to the slides, the fragment is revealed and the horizontal index stays at 0: the test passed without the native-control guard. Compare the full indices before and after instead. Move the changelog entry to its place by issue number in the Accessibility section, and word it as a fix.
Description
Closes #15159.
Closes #15160.
Backport hakimel/reveal.js#3953 to the bundled reveal.js 5.1.0:
asidewith a neutraldiv. The previous/next buttons remain accessible buttons without creating a separate complementary landmark in the main presentation or its preview.The new source patch applies after the three existing reveal.js patches. The dependency-update script now rebuilds the plugins as well as the core, so future updates retain the notes-template fix. Included core UMD/ESM bundles and source maps, notes UMD/ESM bundles, and the speaker-view template were rebuilt from the 5.1.0 source using its Gulp/Rollup pipeline; they are not hand-edited minified bundles. Existing announcement and focus patches are retained.
Validation
The existing physical-Space shortcut behavior on a focused previous-slide button is unchanged and not part of this backport.
Checklist
news/changelog-1.11.mdAI-assisted PR