Skip to content

Fix: initialize IndexedDB with upgrade callback regardless of call order#83

Merged
shikokuchuo merged 4 commits intomainfrom
fix-storage
Mar 26, 2026
Merged

Fix: initialize IndexedDB with upgrade callback regardless of call order#83
shikokuchuo merged 4 commits intomainfrom
fix-storage

Conversation

@shikokuchuo
Copy link
Collaborator

Fixes #82.

userSettings.ts opened the database without the upgrade callback that creates the stores. If it ran before projectStorage.ts (which it does on page load), the database was created empty and the stores were never created.

This PR creates a single shared getDb() in the storage module, used by both services.

@shikokuchuo shikokuchuo marked this pull request as ready for review March 26, 2026 00:55
@shikokuchuo
Copy link
Collaborator Author

@vezwork fyi 9ef140d is a fix for breakage introduced by bb5764a - I've added a regression test so we should be fine in future.

@shikokuchuo shikokuchuo merged commit 6f55d7d into main Mar 26, 2026
4 checks passed
@shikokuchuo shikokuchuo deleted the fix-storage branch March 26, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hub: fails to load as user settings store not found

1 participant