Implement Mixed Magnitude Approximation - #1925
Open
Acciaccatura wants to merge 11 commits into
Open
Conversation
…into issue1759
Acciaccatura
marked this pull request as ready for review
August 20, 2026 02:59
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the mixed_magnitude_approx protocol for approximating unitaries, along with its corresponding exports. The review feedback highlights opportunities to pass the relative_norm_solver parameter down to internal calls (mixed_diagonal_protocol and diagonal_unitary_approx) to respect custom solvers, and suggests avoiding redundant .to_matrix() conversions by passing UnitaryChannel objects directly to from_unitaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi! i tried to attempt a solution for mixed magnitude approximation (https://arxiv.org/pdf/2203.10064) for #1759 - though I am unsure how to test this implementation. it appears I need a
diamond_norm_distance_to_unitaryforProbabilisticChannelimplemented.I've attempted to compute the bounds from Proposition 3.22 in the paper and have received favorable results - e.g.:
any advice? thanks for taking a look!