Skip to content

Separate steps for linting/building #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sburton84 wants to merge 3 commits into
base: main
Choose a base branch
from
+36 −7
Open

Separate steps for linting/building #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a388923
build(CI): separate lint steps
sburton84 Apr 2, 2026
b3e4a1a
Correct step names
sburton84 Apr 2, 2026
16e482b
Removed tokens from job they're not needed for
sburton84 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/pre-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ on:
- '!main' # excludes main

jobs:
release:
lint:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
Expand All @@ -19,11 +18,26 @@ jobs:
cache: 'npm'
# Path to the lock file needs to be specified explicitly as it is not in the root of the repository
cache-dependency-path: 'documentation-ui/package-lock.json'
- name: Lint and build documentation UI JS package
- name: Lint documentation UI JS package
working-directory: documentation-ui
run: |
npm ci
npm run lint

build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 20
cache: 'npm'
# Path to the lock file needs to be specified explicitly as it is not in the root of the repository
cache-dependency-path: 'documentation-ui/package-lock.json'
- name: Build documentation UI JS package
working-directory: documentation-ui
run: |
npm ci
npm run build
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
23 changes: 19 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:
id-token: write

jobs:
release_node:
lint_node:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
Expand All @@ -22,13 +22,28 @@ jobs:
cache: 'npm'
# Path to the lock file needs to be specified explicitly as it is not in the root of the repository
cache-dependency-path: 'documentation-ui/package-lock.json'
- name: Lint and build documentation UI JS package
- name: Lint documentation UI JS package
working-directory: documentation-ui
run: |
npm ci
npm run lint
npm run build

build_and_release_node:
runs-on: ubuntu-latest
needs: lint_node
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 20
cache: 'npm'
# Path to the lock file needs to be specified explicitly as it is not in the root of the repository
cache-dependency-path: 'documentation-ui/package-lock.json'
- name: Build documentation UI JS package
working-directory: documentation-ui
run: |
npm ci
npm run build
- name: Release documentation UI JS package
working-directory: documentation-ui
run: |
Expand All @@ -39,7 +54,7 @@ jobs:

release_pypi:
runs-on: ubuntu-latest
needs: release_node
needs: build_and_release_node
steps:
- uses: actions/checkout@v6
- name: Set up Python
Expand Down