Gstreamer Multimedia TestSuite #250
Conversation
bhargav0610
requested review from
bhargav0610,
smuppand and
vnarapar
and removed request for
bhargav0610
|
@ramyathallam files itself are missing in the PR. Please follow the guidelines.
|
Signed-off-by: ramyathallam <rthallam@qti.qualcomm.com> Signed-off-by: rthallam <rthallam@qti.qualcomm.com> Signed-off-by: ramyathallam <rthallam@qti.qualcomm.com>
Signed-off-by: rthallam <rthallam@qti.qualcomm.com> Signed-off-by: ramyathallam <rthallam@qti.qualcomm.com>
Signed-off-by: ramyathallam <rthallam@qti.qualcomm.com>
Signed-off-by: ramyathallam <rthallam@qti.qualcomm.com>
Implemented comprehensive GStreamer validation with 21 test cases across four independent suites: Video: H.264/H.265/VP9 encode/decode with V4L2 (10 tests) Audio: PulseAudio capture/playback (2 tests) Display: Wayland compositor validation (4 tests) Camera: libcamera capture and encoding (5 tests) Features master runner, per-suite execution, common validation framework, detailed logging, and CI/CD integration (LAVA YAML configs) Signed-off-by: ramyathallam <rthallam@qti.qualcomm.com>
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
Refactor runners to reuse Runner/utils/lib_gstreamer.sh + functestlib.sh (no duplicate pipeline runner frameworks, no CSV/JUnit unless you provide the proper usage and justification). We will review once it fixes all above
| @@ -0,0 +1,322 @@ | |||
| # GStreamer Audio Tests | |||
There was a problem hiding this comment.
Standardize to one canonical location
Runner/suites/Multimedia/Gstreamer/<Audio|Video|Display|Camera>/...
Remove/avoid Runner/suites/Gstreamer/... (top-level under Runner)
|
|
||
| run: | ||
| steps: | ||
| - cd Runner/suites/Gstreamer/Audio |
There was a problem hiding this comment.
After you move suites under Runner/suites/Multimedia/Gstreamer/..., update YAML to:
cd Runner/suites/Multimedia/Gstreamer/Audio
| } | ||
|
|
||
| run_test_suite() { | ||
| local suite_name="$1" |
There was a problem hiding this comment.
Replace local x=... with plain variables (or wrap in subshell patterns carefully).
Run ShellCheck against every added/modified run.sh and keep it clean like your other suites.
| done | ||
| } | ||
|
|
||
| run_test_suite() { |
There was a problem hiding this comment.
Put all GStreamer common logic in:
Runner/utils/lib_gstreamer.sh (extend it)
Keep suite run.sh minimal:
parse args/env
call lib_gstreamer.sh functions to build/run pipelines with timeouts
apply evidence checks (reuse audio_common evidence helpers)
write .res (PASS/FAIL/SKIP only)
If you need “decode/encode matrix”, do it as:
a list of configs inside run.sh or a small .list file in the suite folder
iterate configs, emit per-config logs, aggregate final PASS/FAIL
| # Overall result | ||
| if [ "$pass" -eq 0 ] && [ "$fail" -eq 0 ] && [ "$skip" -gt 0 ]; then | ||
| log_skip "$TESTNAME: SKIP" | ||
| printf '%s\n' "$TESTNAME SKIP" >"$RES_FILE" |
There was a problem hiding this comment.
Some parts imply richer result output (“PASS ”). Your testkit’s LAVA flow typically expects .res to contain only PASS|FAIL|SKIP, and then send-to-lava.sh handles publishing. (Your AudioPlayback follows this.) Make all new suites follow that exact contract.
|
@ramyathallam also look into the workflow failures to address. https://github.com/qualcomm-linux/qcom-linux-testkit/actions/runs/20990382009/job/60470566467?pr=250 |
2 participants
Gstreamer Multimedia TestSuite (Video/Audio/Display/Camera)
Implement comprehensive GStreamer validation with 21 test cases across
four independent suites:
Features master runner, per-suite execution, common validation framework,
detailed logging, and CI/CD integration (LAVA YAML configs).