Skip to content

QCLINUX : Test change#589

Open
sgaud-quic wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
sgaud-quic:qcom-6.18.y-test
Open

QCLINUX : Test change#589
sgaud-quic wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
sgaud-quic:qcom-6.18.y-test

Conversation

@sgaud-quic
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
@sgaud-quic sgaud-quic requested review from a team, knaveen-qc, quicAspratap and rrnayak May 16, 2026 05:43
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@sgaud-quic
Copy link
Copy Markdown
Contributor Author

PR #589 — validate-patch

PR: #589

Verdict Issues Detailed Report
⚠️ 3 Full report
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: QCLINUX: Test change — PR #589
Upstream commit: N/A
Verdict: ⚠️ N/A — Validation not applicable

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix — no upstream lore equivalent
Body preserves rationale N/A Vendor-only commit
Fixes tag present/correct N/A Not required for QCLINUX:
Authorship preserved N/A Vendor-only commit
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts N/A gpi_dma0 status changed okaydisabled; no upstream lore to compare against

Issues

  • No lore.kernel.org link present in the commit message — this is expected for QCLINUX: commits, which are vendor-only changes with no upstream equivalent.
  • The commit subject uses QCLINUX : Test change (note the space before the colon). Convention is QCLINUX: with no space before the colon.
  • The commit body contains only a Signed-off-by: trailer with no rationale or description explaining why gpi_dma0 is being disabled. Even for vendor-only commits, a brief rationale is strongly recommended.

Verdict

Validation skipped — QCLINUX: commits are vendor-only with no upstream lore source; however, the commit should be amended to (1) remove the space before the colon in the prefix (QCLINUX: not QCLINUX :), and (2) add a brief rationale in the commit body explaining why gpi_dma0 is being disabled.

@sgaud-quic
Copy link
Copy Markdown
Contributor Author

PR #589 — checker-log-analyzer

PR: #589
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/25954226335

Checker Result Summary
Checker Result Summary
checkpatch MISSING_COMMIT_DESCRIPTION warning on single commit
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check Log Summary: Test passed
sparse-check ⏭️ Skipping — no C/H files changed
check-uapi-headers ⏭️ Skipping — no C/H files changed
check-patch-compliance QCLINUX : prefix not in allowed list
tag-check QCLINUX : has a trailing space before : — malformed prefix
qcom-next-check N/A QCLINUX: commits are vendor-only; no upstream check required

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: QCLINUX : Test change — #589
Run: https://github.com/qualcomm-linux/kernel-config/actions/runs/25954226335
Target branch: qcom-6.18.y (not qcom-next / qcom-next-staging → tag-check is mandatory)
Commit: c41aab9b4df97b9fff67832cb39c4b921559aa1b
Base SHA: 6964936c9bfc3337aa8ba8a0fb25021d06e5ce04


Checker Result Summary
checkpatch MISSING_COMMIT_DESCRIPTION warning on single commit
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check Log Summary: Test passed
sparse-check ⏭️ Skipping — no C/H files changed
check-uapi-headers ⏭️ Skipping — no C/H files changed
check-patch-compliance QCLINUX : prefix not in allowed list
tag-check QCLINUX : has a trailing space before : — malformed prefix
qcom-next-check N/A QCLINUX: commits are vendor-only; no upstream check required

❌ checkpatch

Root cause: The single commit c41aab9b4df9 ("QCLINUX : Test change") has no commit description body — only a subject line and Signed-off-by:, triggering WARNING: Missing commit description.

Failure details:

WARNING: Missing commit description - Add an appropriate one

c41aab9b4df97b9fff67832cb39c4b921559aa1b total: 0 errors, 1 warnings, 0 checks, 8 lines checked

Commit c41aab9b4df9 ("QCLINUX : Test change") has style problems, please review.

Fix:

git rebase -i 6964936c9bfc   # mark commit as 'edit'
git commit --amend
# Add a description body explaining what the change does and why, e.g.:
#
#   QCLINUX: arm64: dts: qcom: qcs6490-rb3gen2: disable gpi_dma0
#
#   Disable gpi_dma0 on qcs6490-rb3gen2 because <reason>.
#
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES \
  --git 6964936c9bfc3337aa8ba8a0fb25021d06e5ce04..c41aab9b4df97b9fff67832cb39c4b921559aa1b

❌ check-patch-compliance

Root cause: The commit subject QCLINUX : Test change uses QCLINUX : (with a space before the colon), which is not a valid prefix. Even the correctly-spelled QCLINUX: is not in the allowed list for check-patch-compliance (which only accepts FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). This is a known checker limitation for vendor-only commits.

Failure details:

Checking commit: QCLINUX : Test change
Commit summary does not start with a required prefix
##[error]Process completed with exit code 1.

Fix:

  • If this is a vendor-only change with no upstream equivalent: The QCLINUX: prefix will always fail check-patch-compliance — this is a known limitation. Ensure the prefix is correctly formatted as QCLINUX: (no space before :). The checker failure for QCLINUX: commits is expected and cannot be resolved by a patch change alone.
  • If this change has been or will be posted upstream: Change the prefix to FROMLIST: and add a Link: <lore-url> trailer to the commit body.
  • In either case, fix the malformed prefix (remove the space before :):
git rebase -i 6964936c9bfc
# mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: qcs6490-rb3gen2: disable gpi_dma0"
# (add a proper description body too — see checkpatch fix above)
git rebase --continue

Reproduce locally:

b4 am --single-message -C -l -3 <link>   # only applicable if FROMLIST: is used

❌ tag-check

Root cause: The target branch is qcom-6.18.y (not qcom-next / qcom-next-staging), so every commit subject must start with a valid prefix. The subject QCLINUX : Test change has a space before the colon (QCLINUX :) making it malformed — it does not match the required pattern ^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):.

Failure details:

Commit c41aab9b4df9 ("QCLINUX : Test change"):
  subject line does not start with a required prefix.
  (Space before colon: "QCLINUX :" is not "QCLINUX:")

Fix: Rename the commit subject to use a correctly-formatted prefix with no space before ::

git rebase -i 6964936c9bfc
# mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: qcs6490-rb3gen2: disable gpi_dma0

Disable gpi_dma0 on qcs6490-rb3gen2 because <reason>.

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>"
git rebase --continue

Verdict

2 real blockers to fix before merge:

  1. Malformed prefixQCLINUX : (space before :) must be corrected to QCLINUX: in the commit subject.
  2. Missing commit description — the commit body must include a description explaining the change (not just a subject + Signed-off-by:).

Note: Once the prefix is corrected to QCLINUX:, check-patch-compliance will still report a failure — this is a known checker limitation for vendor-only commits using QCLINUX: and does not require a patch change beyond fixing the malformed prefix. The dtb-check warnings visible in the log (from talos-evk-lvds-auo,g133han01.dtso and hamoa-camera.dtsi) are pre-existing tree-wide issues unrelated to this PR's single-line DTS change, and the checker itself reported Log Summary: Test passed after baseline subtraction.

@qcomlnxci
Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ◻️ ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ◻️ ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ◻️ ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ◻️ ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
smmu ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants