Skip to content

phy: qcom: edp: Backport eDP/DP PHY fixes and platform support #568

Open
YongxingMou wants to merge 13 commits into
qualcomm-linux:qcom-6.18.yfrom
YongxingMou:for-eDP-phy
Open

phy: qcom: edp: Backport eDP/DP PHY fixes and platform support #568
YongxingMou wants to merge 13 commits into
qualcomm-linux:qcom-6.18.yfrom
YongxingMou:for-eDP-phy

Conversation

@YongxingMou
Copy link
Copy Markdown

@YongxingMou YongxingMou commented May 12, 2026

Backport a series of fixes and enhancements for the Qualcomm eDP/DP PHY driver:

  • Add PHY-specific LDO config for eDP low vdiff mode
  • Fix AUX_CFG8 programming for DP mode
  • Unify generic DP/eDP swing and pre-emphasis tables
  • Add SC7280/SC8180X platform-specific swing/pre-emphasis tables
  • Add eDP/DP mode switch support
  • Fix NULL pointer dereference for PHY v6 (x1e80100)
  • Fix DP_PHY_AUX_CFG registers count
  • Add v8 DP-specific qserdes-com registers
  • Add Glymur (sa8775p) platform support and dt-bindings

CRs-Fixed:4511768

@YongxingMou YongxingMou requested review from a team, ndechesne, quic-tingweiz and sgaud-quic May 12, 2026 06:57
@YongxingMou
Copy link
Copy Markdown
Author

YongxingMou commented May 12, 2026

revert due to backport latest patch

@quic-khuzuri
Copy link
Copy Markdown

quic-khuzuri commented May 12, 2026

PR #568 — validate-patch

PR: #568

Verdict Issues Detailed Report
⚠️ 0 pr_only_validate_patch_detailed.md
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: PR #568 — phy: qcom: edp: Glymur support + eDP/DP swing/LDO fixes (13 commits)
Upstream commits: Multiple — patch.msgid.link redirects to lore.kernel.org (patches 3–13); patches 1–2 are vendor-local Reverts with no lore link.
Verdict: ⚠️ PARTIAL

Note: Network access was unavailable; upstream lore patches could not be fetched for line-by-line diff comparison. The analysis below is based on commit-message content, tag hygiene, authorship, and structural consistency of the PR patch itself. Diff faithfulness is assessed by internal consistency only.

Commit Message

Patches 1–2 — Revert "FROMLIST: …" (vendor-local, no lore link)

Check Status Note
Subject matches upstream N/A Vendor-local reverts; no upstream equivalent
Body preserves rationale ⚠️ Body only says "This reverts commit <sha>" — no rationale for why the FROMLIST commit is being reverted before being re-applied
Fixes tag present/correct N/A Not a bug-fix commit
Authorship preserved ✅ From: Yongxing Mou is the committer performing the revert
Backport note N/A Not a backport
Prefix before Revert ⚠️ Per tree convention, Revert commits should carry a prefix (e.g. QCLINUX: Revert "…" or PENDING: Revert "…"). Both patches have bare Revert "…" subjects with no vendor prefix.
Signed-off-by present ❌ Neither patch 1 nor patch 2 carries any Signed-off-by: line — required by kernel DCO rules.

Patches 3–13 — BACKPORT: / FROMLIST: commits

Check Patch(es) Status Note
Subject matches upstream 3–13 ✅ Subjects match lore message-IDs embedded in Link: tags
Body preserves rationale 3–13 ✅ Commit bodies faithfully reproduce upstream rationale
Fixes tag present/correct 8, 9, 10, 12, 13 ✅ Correct upstream SHAs and subjects cited
Fixes tag absent where expected 11 ✅ Patch 11 adds new tables (not a bug-fix); no Fixes: needed
Authorship preserved (BACKPORT:) 3–7 ✅ From: matches lore author (Abel Vesa); dual Signed-off-by: (linaro + oss.qualcomm) is normal for dual-affiliation
Authorship preserved (BACKPORT:) 8 ✅ From: Val Packett matches lore author
Authorship preserved (BACKPORT:) 9–13 ✅ From: Yongxing Mou matches lore author
Authorship preserved (FROMLIST:) 4 ✅ From: Ritesh Kumar is the lore author; Signed-off-by: present
Backport note [ upstream commit <sha> ] 3–13 ⚠️ No [ upstream commit <sha> ] note in any BACKPORT commit body — recommended for traceability
Link: format 3–13 ✅ patch.msgid.link/… is a valid redirect to lore.kernel.org; patch 4 uses direct lore.kernel.org URL
Tag ordering (Reviewed-by before final SOB) 7, 11 ⚠️ Patch 7: Reviewed-by: Dmitry Baryshkov appears between two Signed-off-by: Abel Vesa lines. Patch 11: Reviewed-by: Konrad Dybcio appears after Signed-off-by: Yongxing Mou but before maintainer SOB — unusual but not blocking

Diff

Patch File(s) Status Notes
01 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Clean revert of one line (swing_pre_emph_cfg for sc7280)
02 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml, phy/qcom,edp-phy.yaml ✅ Clean revert of ref-clock addition and sa8775p-edp-phy from allOf enum
03 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml ✅ Adds qcom,glymur-dp-phy to compatible enum and allOf clause; consistent with lore series v6 patch 1
04 qcom,sa8775p-mdss.yaml, qcom,edp-phy.yaml ✅ Re-adds GCC_EDP_REF_CLKREF_EN clock and sa8775p-edp-phy to allOf; exact inverse of patch 02 — logically consistent
05 drivers/phy/qualcomm/phy-qcom-edp.c ✅ DP_AUX_CFG_SIZE 10→13; matches lore series v6 patch 2
06 drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h (new) ✅ New header with 40 register offsets; matches lore series v6 patch 3
07 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Large Glymur v8 PHY addition; structurally consistent with lore series v6 patch 4
08 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Adds com_clk_fwd_cfg stub to v6 ops; matches lore single-patch
09 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Unifies swing/pre-emphasis tables; Cc: stable@vger.kernel.org present
10 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Splits swing_pre_emph_cfg into dp_/edp_ variants; Cc: stable present
11 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Adds SC7280/SC8180X-specific tables and splits sc8180x_dp_phy_cfg from sc7280
12 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Simplifies AUX_CFG8 condition to !edp->is_edp; Cc: stable present
13 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Introduces com_ldo_config callback per PHY version; Cc: stable present

Issues

  1. Patches 1 & 2 — Missing Signed-off-by: Both revert commits lack any Signed-off-by: line. This violates the kernel DCO requirement (every commit must be signed off by its author). The committer Yongxing Mou must add Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> to each.

  2. Patches 1 & 2 — Missing vendor prefix on Revert subject. Per this tree's convention, revert commits should carry a prefix before Revert (e.g. QCLINUX: Revert "…" if vendor-only, or the appropriate upstream prefix). Bare Revert "…" subjects are ambiguous about the commit's upstream status.

  3. All BACKPORT patches (3–13) — No [ upstream commit <sha> ] note. While not strictly mandatory, the absence of an upstream SHA note in the commit body makes it harder to trace which exact upstream commit was backported. Recommended practice is to add a line such as [ upstream commit add66a6673bc ] at the end of the body.

  4. Patch 7 — Reviewed-by: between two Signed-off-by: lines from the same author. The tag block reads: Signed-off-by: Abel Vesa <abel.vesa@linaro.org> → Reviewed-by: Dmitry Baryshkov → Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>. This is a cosmetic ordering anomaly (likely preserved from the lore posting) but is not a blocking issue.

  5. Patch 11 — Reviewed-by: after author's Signed-off-by:. Reviewed-by: Konrad Dybcio appears after Signed-off-by: Yongxing Mou — minor tag ordering issue, not blocking.

  6. Patch 8 — Fixes: SHA add66a6673bc references the upstream commit, not the in-tree BACKPORT SHA. This is actually correct behavior for BACKPORT commits (Fixes: should cite the upstream SHA), but reviewers should be aware the in-tree SHA for patch 7 is 1c5424a1420f6fdcaf0c6800cb4ac5b046f14b0a.

Verdict

The series is structurally sound and the BACKPORT/FROMLIST patches carry proper authorship, lore Link: tags, and correct Fixes: citations. The two blocking issues are the missing Signed-off-by: on patches 1 and 2 and the missing vendor prefix on their Revert subjects — these must be corrected before merge. All other findings are minor cosmetic/traceability improvements.

@quic-khuzuri
Copy link
Copy Markdown

quic-khuzuri commented May 12, 2026

PR #568 — checker-log-analyzer

PR: #568
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/25718801892

Checker Result Summary
Checker Result Summary
checkpatch ❌ 2× MISSING_SIGN_OFF (ERROR); 1× multiple blank lines (CHECK)
dt-binding-check ✅ qcom,edp-phy.yaml — dt_binding_check + dtbs_check both passed
dtb-check ⏭️ Skipped — no DTS file changes in this PR
sparse-check ✅ Passed (only pre-existing nouveau warnings, not from PR files)
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 2 commits missing required prefix (Revert "FROMLIST: …" bare subjects)
tag-check ❌ Same 2 Revert commits lack a prefix — target branch is qcom-6.18.y (not qcom-next)
qcom-next-check ⏭️ Skipped (network unavailable in sandbox); manually verify FROMLIST: commit below

Detailed report: pr_only_checker_log_detailed.md

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #568 — eDP PHY refactor/Glymur support (qcom-6.18.y)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/25718801892
Base → Head: 2eda00b1ebc2 → d3c7f39738b7 (13 commits)

Checker Result Summary
checkpatch ❌ 2× MISSING_SIGN_OFF (ERROR); 1× multiple blank lines (CHECK)
dt-binding-check ✅ qcom,edp-phy.yaml — dt_binding_check + dtbs_check both passed
dtb-check ⏭️ Skipped — no DTS file changes in this PR
sparse-check ✅ Passed (only pre-existing nouveau warnings, not from PR files)
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 2 commits missing required prefix (Revert "FROMLIST: …" bare subjects)
tag-check ❌ Same 2 Revert commits lack a prefix — target branch is qcom-6.18.y (not qcom-next)
qcom-next-check ⏭️ Skipped (network unavailable in sandbox); manually verify FROMLIST: commit below

❌ checkpatch

Root cause: Two Revert commits (5a82baae, cdee1f8c) are missing Signed-off-by: lines, and commit 1c5424a1 has consecutive blank lines in the driver source.

Failure details:

Commit 5a82baae5557 ("Revert "FROMLIST: phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280"")
ERROR: Missing Signed-off-by: line(s)
5a82baae5557 total: 1 errors, 0 warnings, 0 checks, 7 lines checked

Commit cdee1f8c0419 ("Revert "FROMLIST: dt-bindings: phy: qcom-edp: Add eDP ref clk for sa8775p"")
ERROR: Missing Signed-off-by: line(s)
cdee1f8c0419 total: 1 errors, 0 warnings, 0 checks, 20 lines checked

Commit 1c5424a1420f ("BACKPORT: phy: qcom: edp: Add Glymur platform support")
CHECK: Please don't use multiple blank lines
#305: FILE: drivers/phy/qualcomm/phy-qcom-edp.c:895:
1c5424a1420f total: 0 errors, 0 warnings, 1 checks, 332 lines checked

Fix:

# For the two Revert commits — add Signed-off-by to each:
git rebase -i 2eda00b1ebc2
# mark 5a82baae and cdee1f8c as 'edit'
git commit --amend   # add: Signed-off-by: Your Name <your@email>
git rebase --continue

# For 1c5424a1 — remove the extra blank line at phy-qcom-edp.c:895:
git rebase -i 2eda00b1ebc2
# mark 1c5424a1 as 'edit', remove the duplicate blank line, then:
git add drivers/phy/qualcomm/phy-qcom-edp.c
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES \
  --git 2eda00b1ebc26941a0aae653b455e47662b1d94f..d3c7f39738b7c14b19f7f5319571e345308f690e

❌ check-patch-compliance / tag-check

Root cause: Commits 01/13 and 02/13 use bare Revert "FROMLIST: …" subjects with no required prefix before Revert, which fails both the compliance checker and the tag-check rule for qcom-6.18.y.

Failure details:

Checking commit: Revert "FROMLIST: phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280"
Commit summary does not start with a required prefix

Checking commit: Revert "FROMLIST: dt-bindings: phy: qcom-edp: Add eDP ref clk for sa8775p"
Commit summary does not start with a required prefix

The target branch is qcom-6.18.y (not qcom-next / qcom-next-staging), so every commit must start with FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:. A bare Revert "…" subject has no such prefix.

Fix: Prepend BACKPORT: (or QCLINUX: if these reverts are vendor-only) to each revert subject:

git rebase -i 2eda00b1ebc2
# mark both Revert commits as 'edit'

# Commit 1:
git commit --amend -m 'BACKPORT: Revert "FROMLIST: phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280"'
git rebase --continue

# Commit 2:
git commit --amend -m 'BACKPORT: Revert "FROMLIST: dt-bindings: phy: qcom-edp: Add eDP ref clk for sa8775p"'
git rebase --continue

Choose BACKPORT: if these reverts track an upstream revert; choose QCLINUX: if they are vendor-only.

Reproduce locally:

bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src <kernel-src> \
  --base 2eda00b1ebc26941a0aae653b455e47662b1d94f \
  --head d3c7f39738b7c14b19f7f5319571e345308f690e

⚠️ qcom-next-check (advisory)

Commit 35ac9cc44917 (FROMLIST: dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY) carries a FROMLIST: prefix. Network access was unavailable to verify its presence in qcom-next. Manually confirm:

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git qcom-next
git log qcom-linux/qcom-next --oneline --grep="dt-bindings: phy: qcom-edp: Add reference clock for sa8775p"

If not found, flag for reviewer attention before merging into qcom-6.18.y.

Verdict

2 blockers to fix before merge:

  1. Add Signed-off-by: to commits 5a82baae and cdee1f8c (checkpatch ERROR).
  2. Add a valid prefix (BACKPORT: or QCLINUX:) before Revert "…" on the same two commits (check-patch-compliance + tag-check FAIL).

The CHECK-level double-blank-line in 1c5424a1 (phy-qcom-edp.c:895) is non-blocking but should be cleaned up. All other checkers (dt-binding-check, dtb-check, sparse-check, check-uapi-headers) passed or were correctly skipped.

shashim-quic
shashim-quic requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown

@shashim-quic shashim-quic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts commit be56e44.

Always mention reason for revert in commit log.

Yongxing Mou and others added 13 commits May 14, 2026 16:47
Revert "FROMLIST: phy: qcom: edp: Initialize swing_pre_emph_cfg for s…
b26efee 
…c7280"

This reverts commit be56e44.
This patch is outdated, and its functionality has already been replaced by
a newer patch that has been accepted upstream.

Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Revert "FROMLIST: dt-bindings: phy: qcom-edp: Add eDP ref clk for sa8…
fba183c 
…775p"

This reverts commit 7de61f2.
This patch is outdated. A newer patch exists upstream; please backport
the v4 version of that patch.

Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
@abelvesa
BACKPORT: dt-bindings: phy: Add DP PHY compatible for Glymur
95fed1c 
The Glymur platform is the first one to use the eDP PHY version 8.
This makes it incompatible with any of the earlier platforms and therefore
requires a dedicated compatible. So document it.

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Link: https://patch.msgid.link/20251224-phy-qcom-edp-add-glymur-support-v6-1-4fcba75a6fa9@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
@riteshk-quic
FROMLIST: dt-bindings: phy: qcom-edp: Add reference clock for sa8775p…
202ee38 
… eDP PHY

The initial sa8775p eDP PHY binding contribution missed adding support for
voting on the eDP reference clock. This went unnoticed because the UFS PHY
driver happened to enable the same clock.

After commit 77d2fa5 ("scsi: ufs: qcom : Refactor phy_power_on/off
calls"), the eDP reference clock is no longer kept enabled, which results
in the following PHY power-on failure:

phy phy-aec2a00.phy.10: phy poweron failed --> -110

To fix this, explicit voting for the eDP reference clock is required.
This patch adds the eDP reference clock for sa8775p eDP PHY and updates
the corresponding example node.

Link: https://lore.kernel.org/all/20260128114853.2543416-2-quic_riteshk@quicinc.com/
Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
@abelvesa
BACKPORT: phy: qcom: edp: Fix the DP_PHY_AUX_CFG registers count
ff3760f 
On all platforms supported by this driver, there are 13 DP_PHY_AUX_CFGx
registers. This hasn't been an issue so far on currently supported
platforms, because the init sequence never spanned beyond DP_PHY_AUX_CFG9.

However, on the new upcoming Glymur platform, these are updated along
with the rest of the init sequence.

So update the size of the array holding the config to 13.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Link: https://patch.msgid.link/20251224-phy-qcom-edp-add-glymur-support-v6-2-4fcba75a6fa9@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
@abelvesa
BACKPORT: phy: qcom-qmp: qserdes-com: Add v8 DP-specific qserdes regi…
475b6b5 
…ster offsets

Starting with Glymur, the PCIe and DP PHYs qserdes register offsets differ
for the same version number. So in order to be able to differentiate
between them, add these ones with DP prefix.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Link: https://patch.msgid.link/20251224-phy-qcom-edp-add-glymur-support-v6-3-4fcba75a6fa9@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
@abelvesa
BACKPORT: phy: qcom: edp: Add Glymur platform support
3e4410d 
The Qualcomm Glymur platform has the new v8 version of the eDP/DP PHY.
So rework the driver to support this new version and add the platform
specific configuration data.

While at it, add the rest of the AUX_CFG reset values for the v4 and v5
platforms, which makes the handling of the platforms specific array
cleaner, as they are single sized now.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Link: https://patch.msgid.link/20251224-phy-qcom-edp-add-glymur-support-v6-4-4fcba75a6fa9@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
@valpackett
BACKPORT: phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1…
a89c01c 
…e80100)

For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a
stub implementation was added for the v4 of the hardware. However it
was omitted for the v6, causing a NULL pointer dereference oops on
Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub.

Fixes: add66a6 ("phy: qcom: edp: Add Glymur platform support")
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Val Packett <val@packett.cool>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tested-by: Yijie Yang <yijie.yang@oss.qualcomm.com> # Purwa-IoT-EVK
Link: https://patch.msgid.link/20260111083317.604754-1-val@packett.cool
Signed-off-by: Vinod Koul <vkoul@kernel.org>
BACKPORT: phy: qcom: edp: Unify generic DP/eDP swing and pre-emphasis…
15f2f48 
… tables

The current eDP and DP swing/pre-emphasis tables do not match the HPG
requirements for the supported platforms, correct the table accordingly.

The generic tables which can be shared as follows:

DP mode：
	-sa8775p/sc7280/sc8280xp/x1e80100
	-glymur
	-sc8180x
eDP mode(low vdiff):
	-glymur/sa8775p/sc8280xp/x1e80100
	-sc7280
	-sc8180x

The proper tables for SC8180X and SC7280 will be added in a later patch,
since they need separate table.

Cc: stable@vger.kernel.org
Fixes: f199223 ("phy: qcom: Introduce new eDP PHY driver")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Link: https://patch.msgid.link/20260427-edp_phy-v5-1-3bb876824475@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
BACKPORT: phy: qcom: edp: Add eDP/DP mode switch support
1dd4c4d 
The eDP PHY supports both eDP/DP modes, each requiring a different
swing/pre-emphasis table. However, the driver currently uses a fixed
static table for eDP programming rather than selecting the appropriate
table based on the current mode. Add separate tables for eDP and DP
modes, and select the appropriate table dynamically based on the
current mode.

Glymur's DP mode table differs from the other platforms, add a
dedicated table for it.

This also fixes the table mismatch for X1E80100 (eDP) and SA8775P (DP).

Cc: stable@vger.kernel.org
Fixes: 3f12bf1 ("phy: qcom: edp: Add support for eDP PHY on SA8775P")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Link: https://patch.msgid.link/20260427-edp_phy-v5-2-3bb876824475@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
BACKPORT: phy: qcom: edp: Add SC7280/SC8180X swing/pre-emphasis tables
a05e025 
SC7280 and SC8180X previously shared the same cfg because they did not use
swing/pre-emphasis tables. Add the corresponding tables for these
platforms. Since they have different PHY sub-versions, their eDP/DP mode
tables also differ, so move SC8180X to its own cfg instead of reusing the
SC7280 one.

Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://patch.msgid.link/20260427-edp_phy-v5-3-3bb876824475@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
BACKPORT: phy: qcom: edp: Fix AUX_CFG8 programming for DP mode
86eca90 
AUX_CFG8 depends on whether the PHY is operating in eDP or DP mode, not
the selected swing/pre-emphasis table. All supported platforms already
have the proper tables, so remove the unnecessary check.

Cc: stable@vger.kernel.org
Fixes: 6078b8c ("phy: qcom: edp: Add set_mode op for configuring eDP/DP submode")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Link: https://patch.msgid.link/20260427-edp_phy-v5-4-3bb876824475@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
BACKPORT: phy: qcom: edp: Add PHY-specific LDO config for eDP low vdiff
cbbc899 
For eDP low vdiff, the LDO setting depends on the PHY version rather
than being a simple 0x0 or 0x1 value. Introduce a PHY callback to program
the correct LDO setting according to the HPG.

Since SC7280/SC8180X uses different LDO settings from SA8775P/SC8280XP,
introduce qcom_edp_phy_ops_v3 to keep the LDO setting correct.

Cc: stable@vger.kernel.org
Fixes: f199223 ("phy: qcom: Introduce new eDP PHY driver")
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> # SC8280XP X13s
Link: https://patch.msgid.link/20260427-edp_phy-v5-5-3bb876824475@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
@YongxingMou
Copy link
Copy Markdown
Author

YongxingMou commented May 14, 2026

This reverts commit be56e44.

Always mention reason for revert in commit log.

hi , updated the reverted change commmit message. thanks

@qcomlnxci qcomlnxci requested a review from a team May 14, 2026 08:56
@sgaud-quic
Copy link
Copy Markdown
Contributor

sgaud-quic commented May 14, 2026

PR #568 — validate-patch

PR: #568

Verdict Issues Detailed Report
⚠️ 0 Full report
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: PR #568 — phy: qcom: edp: Glymur support + eDP/DP swing/LDO fixes (13 commits)
Upstream commits: patch.msgid.link redirects (patches 3–13 carry valid Link: tags); patches 1–2 are vendor-local Reverts with no upstream lore equivalent.
Verdict: ⚠️ PARTIAL

Note: Network access was unavailable; lore patches could not be fetched for line-by-line diff comparison. Analysis is based on commit-message content, tag hygiene, authorship, structural consistency, and delta against the previous PR revision (run 25718801892, 2026-05-12).

What Changed Since the Previous Run (2026-05-12)

The two blocking issues from the prior report have been addressed:

  • Patches 1 & 2 now carry Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> ✅
  • Patches 1 & 2 now carry a commit body explaining the rationale for the revert ✅

All other patches (3–13) are content-identical to the previous run (only commit SHAs differ due to the amended patches 1–2 cascading through the series).

Commit Message

Patches 1–2 — Revert "FROMLIST: …" (vendor-local, no lore link)

Check Status Note
Subject matches upstream N/A Vendor-local reverts; no upstream equivalent
Body preserves rationale ✅ Body now explains why the FROMLIST commit is being reverted
Fixes tag present/correct N/A Not a bug-fix commit
Authorship preserved ✅ From: Yongxing Mou is the committer performing the revert
Signed-off-by present ✅ Fixed — both patches now carry Signed-off-by: Yongxing Mou
Vendor prefix before Revert ⚠️ Still bare Revert "FROMLIST: …" subjects — no QCLINUX: or other prefix indicating upstream status of the revert itself
Backport note N/A Not a backport

Patches 3–13 — BACKPORT: / FROMLIST: commits

Check Patch(es) Status Note
Subject matches upstream 3–13 ✅ Subjects match lore message-IDs in Link: tags
Body preserves rationale 3–13 ✅ Commit bodies faithfully reproduce upstream rationale
Fixes tag present/correct 8, 9, 10, 12, 13 ✅ Correct upstream SHAs and subjects cited
Fixes tag absent where expected 3, 4, 5, 6, 7, 11 ✅ New features / table additions — no Fixes: needed
Cc: stable@vger.kernel.org 9, 10, 12, 13 ✅ Present on all bug-fix BACKPORT commits
Authorship (BACKPORT: 3–7) 3–7 ✅ From: Abel Vesa matches lore author; dual Signed-off-by: (linaro + oss.qualcomm) is normal for dual-affiliation
Authorship (BACKPORT: 8) 8 ✅ From: Val Packett matches lore author
Authorship (BACKPORT: 9–13) 9–13 ✅ From: Yongxing Mou matches lore author
Authorship (FROMLIST: 4) 4 ✅ From: Ritesh Kumar is the lore author; Signed-off-by: present
[ upstream commit <sha> ] note 3–13 ⚠️ No upstream SHA note in any BACKPORT body — recommended for traceability
Link: format 3–13 ✅ patch.msgid.link/… is a valid lore redirect; patch 4 uses direct lore.kernel.org URL
Tag ordering (patch 7) 7 ⚠️ Reviewed-by: Dmitry Baryshkov appears between two Signed-off-by: Abel Vesa lines — cosmetic, not blocking
Tag ordering (patch 11) 11 ⚠️ Reviewed-by: Konrad Dybcio appears after author's Signed-off-by: — minor, not blocking

Diff

Patch File(s) Status Notes
01 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Clean revert of one line (swing_pre_emph_cfg for sc7280)
02 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml, phy/qcom,edp-phy.yaml ✅ Clean revert of ref-clock addition and sa8775p-edp-phy from allOf enum
03 Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml ✅ Adds qcom,glymur-dp-phy to compatible enum and allOf clause; consistent with lore series v6 patch 1
04 qcom,sa8775p-mdss.yaml, qcom,edp-phy.yaml ✅ Re-adds GCC_EDP_REF_CLKREF_EN clock and sa8775p-edp-phy to allOf; exact inverse of patch 02 — logically consistent
05 drivers/phy/qualcomm/phy-qcom-edp.c ✅ DP_AUX_CFG_SIZE 10→13; matches lore series v6 patch 2
06 drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h (new) ✅ New header with 40 register offsets; matches lore series v6 patch 3
07 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Large Glymur v8 PHY addition; structurally consistent with lore series v6 patch 4
08 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Adds com_clk_fwd_cfg stub to v6 ops to fix NULL deref on X1E/X1P; matches lore single-patch
09 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Unifies generic DP/eDP swing/pre-emphasis tables; Cc: stable present
10 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Splits swing_pre_emph_cfg into dp_/edp_ variants; Cc: stable present
11 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Adds SC7280/SC8180X-specific tables; splits sc8180x_dp_phy_cfg from sc7280
12 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Simplifies AUX_CFG8 condition to !edp->is_edp; Cc: stable present
13 drivers/phy/qualcomm/phy-qcom-edp.c ✅ Introduces com_ldo_config callback per PHY version; Cc: stable present

Upstream Patch Status

Commit Community Verdict
Patch 03 — dt-bindings: Add DP PHY compatible for Glymur ✅ ACKed — Acked-by: Rob Herring; Signed-off-by: Vinod Koul (maintainer applied); lore series v6
Patch 04 — dt-bindings: Add reference clock for sa8775p eDP PHY ⏳ Decision Pending — FROMLIST: posting at lore.kernel.org/all/20260128114853.2543416-2; no merge confirmation available offline
Patches 05–07 — Glymur v8 PHY series (v6) ✅ ACKed — Signed-off-by: Vinod Koul <vkoul@kernel.org> (phy subsystem maintainer applied); lore series v6
Patch 08 — Fix NULL pointer dereference on X1E/X1P ✅ ACKed — Signed-off-by: Vinod Koul <vkoul@kernel.org>; multiple Reviewed-by: tags
Patches 09–13 — eDP/DP swing/LDO fix series (v5) ✅ ACKed — Signed-off-by: Vinod Koul <vkoul@kernel.org> on all five; Cc: stable on bug-fix patches

Dependency Check

  • Patches 1–2 (reverts) correctly precede patches 3–4 (re-application of updated versions) — ordering is correct
  • Patch 05 (DP_AUX_CFG_SIZE 10→13) is a prerequisite for patch 07 (Glymur v8 aux_cfg arrays) — correctly ordered
  • Patch 06 (new phy-qcom-qmp-qserdes-dp-com-v8.h header) is a prerequisite for patch 07 — correctly ordered
  • Patch 07 (Glymur platform support) is a prerequisite for patch 08 (Fixes: add66a6673bc) — correctly ordered
  • Patches 09–10 (swing table unification) are prerequisites for patches 11–13 — correctly ordered
  • No missing header/helper changes detected

qcom-next Presence

Commit Status
All patches (03–13) ⏭️ Skipped — network access unavailable; verify manually against https://github.com/qualcomm-linux/kernel qcom-next branch

Issues

  1. Patches 1 & 2 — Missing vendor prefix on Revert subject (remaining from prior run)
    Subjects read Revert "FROMLIST: …" with no leading prefix. Per tree convention, revert commits should carry a prefix indicating their upstream status (e.g. QCLINUX: Revert "FROMLIST: …" for a vendor-only revert). Without a prefix, check-patch-compliance and reviewers cannot classify these commits. This is a minor issue — not blocking merge but should be corrected for consistency.

  2. All BACKPORT patches (3–13) — No [ upstream commit <sha> ] note
    None of the BACKPORT commit bodies include a [ upstream commit <sha> ] line. While not strictly mandatory, this is strongly recommended practice for traceability (allows git log --grep to find the in-tree backport from the upstream SHA). Suggested addition at the end of each body: [ upstream commit <sha> ].

  3. Patch 7 — Reviewed-by: between two Signed-off-by: lines from the same author (cosmetic)
    Tag block: Signed-off-by: Abel Vesa <abel.vesa@linaro.org> → Reviewed-by: Dmitry Baryshkov → Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>. Preserved from lore posting; not blocking.

  4. Patch 11 — Reviewed-by: after author's Signed-off-by: (cosmetic)
    Reviewed-by: Konrad Dybcio appears after Signed-off-by: Yongxing Mou — minor tag ordering anomaly, not blocking.

Verdict

The two blocking issues from the previous run (missing Signed-off-by: and missing commit body on patches 1–2) have been fixed. The series is now in good shape: all BACKPORT/FROMLIST patches carry correct authorship, valid Link: tags, proper Fixes: citations, and Cc: stable where appropriate. The one remaining actionable item is adding a vendor prefix (e.g. QCLINUX:) before the Revert subject on patches 1 and 2 — this is a minor convention issue, not a blocker. The series may be merged after addressing that prefix, or accepted as-is if the tree maintainer considers it acceptable.

@sgaud-quic
Copy link
Copy Markdown
Contributor

sgaud-quic commented May 14, 2026

PR #568 — checker-log-analyzer

PR: #568
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/25851165567

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1× CHECK + 1× WARNING across 2 commits
dt-binding-check ✅ dt_binding_check and dtbs_check both passed for qcom,edp-phy.yaml
dtb-check ⏭️ No changes in Devicetree — skipped
sparse-check ✅ sparse-check.sh passed
check-uapi-headers ✅ No UAPI header changes detected
check-patch-compliance ❌ 2 commits missing required prefix (Revert "FROMLIST: …" without a leading prefix)
tag-check ❌ Same 2 Revert commits lack a valid subject prefix
qcom-next-check ⏭️ Network unavailable; cannot fetch qcom-next — manual verification required

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #568 — phy: qcom: edp — Glymur/sa8775p eDP/DP support
Run: https://github.com/qualcomm-linux/kernel-config/actions/runs/25851165567
Target branch: qcom-6.18.y (not qcom-next / qcom-next-staging → tag-check is mandatory)
Base SHA: 9a4537ba60cc7332c642471323e32f85df771053
Head SHA: cbbc899fc3a3370bc3cbe9f036e0c5b48b2e1308

Checker Result Summary
checkpatch ❌ 1× CHECK + 1× WARNING across 2 commits
dt-binding-check ✅ dt_binding_check and dtbs_check both passed for qcom,edp-phy.yaml
dtb-check ⏭️ No changes in Devicetree — skipped
sparse-check ✅ sparse-check.sh passed
check-uapi-headers ✅ No UAPI header changes detected
check-patch-compliance ❌ 2 commits missing required prefix (Revert "FROMLIST: …" without a leading prefix)
tag-check ❌ Same 2 Revert commits lack a valid subject prefix
qcom-next-check ⏭️ Network unavailable; cannot fetch qcom-next — manual verification required

❌ checkpatch

Root cause: Two commits have minor style issues — one has consecutive blank lines (CHECK: Please don't use multiple blank lines) and one references an unknown commit SHA in a Fixes: tag (WARNING: Unknown commit id).

Failure details:

Commit 3e4410dbb794 ("BACKPORT: phy: qcom: edp: Add Glymur platform support")
CHECK: Please don't use multiple blank lines
#305: FILE: drivers/phy/qualcomm/phy-qcom-edp.c:895:
+
+
3e4410dbb794 total: 0 errors, 0 warnings, 1 checks, 332 lines checked

Commit a89c01cb1957 ("BACKPORT: phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100)")
WARNING: Unknown commit id 'add66a6673bc', maybe rebased or not pulled?
#12:
Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support")
a89c01cb1957 total: 0 errors, 1 warnings, 0 checks, 7 lines checked

Fix:

  1. Commit 3e4410dbb794 — remove the extra blank line at drivers/phy/qualcomm/phy-qcom-edp.c:895:

    git rebase -i 9a4537ba60cc   # mark 3e4410dbb794 as 'edit'
# remove the duplicate blank line at line 895
git add drivers/phy/qualcomm/phy-qcom-edp.c
git commit --amend --no-edit
git rebase --continue

  2. Commit a89c01cb1957 — the Fixes: tag references add66a6673bc which is the short SHA of commit 3e4410dbb794 in the PR itself (not yet in the base branch). After the rebase in step 1, the SHA of the "Add Glymur platform support" commit will change. Update the Fixes: tag to match the new SHA, or use the upstream mainline SHA if this is a backport of an upstream fix. The warning is benign if the commit is intentionally referencing a same-series commit, but the SHA must be correct after any rebase.

    git rebase -i 9a4537ba60cc   # mark a89c01cb1957 as 'edit'
git commit --amend   # update Fixes: tag with correct SHA
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES \
  --git 9a4537ba60cc7332c642471323e32f85df771053..cbbc899fc3a3370bc3cbe9f036e0c5b48b2e1308

❌ check-patch-compliance

Root cause: Two Revert commits have subject lines that start directly with Revert "FROMLIST: …" without a leading prefix tag, which the compliance checker requires.

Failure details:

Checking commit: Revert "FROMLIST: phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280"
Commit summary does not start with a required prefix

Checking commit: Revert "FROMLIST: dt-bindings: phy: qcom-edp: Add eDP ref clk for sa8775p"
Commit summary does not start with a required prefix

All other 11 commits (BACKPORT: and FROMLIST:) passed compliance checks cleanly.

Fix: Prepend the appropriate prefix to each Revert commit subject. Since these are reverting FROMLIST: patches that were previously applied to this stable branch, the correct prefix is FROMLIST: (or BACKPORT: if the revert itself was adapted):

git rebase -i 9a4537ba60cc   # mark both Revert commits as 'edit'

# Commit 1 (b26efeef66c2):
git commit --amend -m 'FROMLIST: Revert "FROMLIST: phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280"'

# Commit 2 (fba183c48ddc):
git commit --amend -m 'FROMLIST: Revert "FROMLIST: dt-bindings: phy: qcom-edp: Add eDP ref clk for sa8775p"'

git rebase --continue

Note: If these reverts have no upstream equivalent (i.e. they are vendor-only cleanups), use QCLINUX: instead of FROMLIST:. In that case check-patch-compliance will still flag them as a known limitation for QCLINUX: commits, but tag-check will pass.

❌ tag-check

Root cause: Same two Revert commits — their subject lines do not start with any of the required prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:). The target branch is qcom-6.18.y, so the prefix check is mandatory.

Offending commits:

  • b26efeef66c2 — Revert "FROMLIST: phy: qcom: edp: Initialize swing_pre_emph_cfg for sc7280"
  • fba183c48ddc — Revert "FROMLIST: dt-bindings: phy: qcom-edp: Add eDP ref clk for sa8775p"

Fix: Same rebase as described in the check-patch-compliance section above — add FROMLIST: (or QCLINUX:) before Revert.

⏭️ qcom-next-check

Network access was unavailable in this environment; qcom-next could not be fetched. The PR contains one FROMLIST: commit that should be verified manually:

  • 202ee38a3b18 — FROMLIST: dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY

Manual verification:

git remote add qcom-linux https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git
git fetch qcom-linux qcom-next
git log qcom-linux/qcom-next --oneline --grep="dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY"

Verdict

2 blockers to fix before merge. The two Revert commits (b26efeef66c2, fba183c48ddc) must have a valid subject prefix added — this fixes both check-patch-compliance and tag-check in one rebase. Additionally, commit 3e4410dbb794 has a trivial double-blank-line style issue (CHECK) and commit a89c01cb1957 has a WARNING about an unresolvable Fixes: SHA — both are low-severity but should be cleaned up. The dt-binding-check, dtb-check, sparse-check, and check-uapi-headers all passed cleanly.

@YongxingMou YongxingMou requested a review from shashim-quic May 15, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndechesne ndechesne Awaiting requested review from ndechesne ndechesne was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

@quic-tingweiz quic-tingweiz Awaiting requested review from quic-tingweiz quic-tingweiz was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

@sgaud-quic sgaud-quic Awaiting requested review from sgaud-quic sgaud-quic was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

@shashim-quic shashim-quic Awaiting requested review from shashim-quic

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@YongxingMou @quic-khuzuri @sgaud-quic @shashim-quic @abelvesa @riteshk-quic @valpackett