Handle zero-dimensional NumPy array comparisons and replacements - #626
Open
jackwalkerlabs wants to merge 1 commit into
Open
Handle zero-dimensional NumPy array comparisons and replacements#626jackwalkerlabs wants to merge 1 commit into
jackwalkerlabs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare zero-dimensional NumPy arrays as scalar values instead of trying to iterate them. Handle scalar/array shape changes through the normal value/type comparison path, and restore the recorded NumPy dtype when a Delta replaces a whole array.
Fixes #463.
Validation: all 13 initial regression cases fail on the base. Final broader suite: 1289 passed, 44 skipped, one deselected. Coverage includes equal/changed integers, floats, strings and booleans; nested arrays; ignore-order, precision, epsilon and NaN options; numeric/bool Delta round trips, scalar/vector shape changes, nested replacements, and invalid dtype rejection. The excluded RLIMIT_AS security test fails on this macOS host on the base too. Existing source lint violations remain;
git diff --checkpasses. String-array Delta serialization still has the existing unsupportedstr_dtype limitation; string comparison itself is covered.AI disclosure: Implemented, reviewed, and tested by OpenAI Codex under the account owner’s authorization; no human code review is claimed.