Keep Unicode readable in CLI JSON output across serializers - #625
Open
jackwalkerlabs wants to merge 1 commit into
Open
Keep Unicode readable in CLI JSON output across serializers#625jackwalkerlabs wants to merge 1 commit into
jackwalkerlabs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep non-ASCII names and values readable in
deep diffJSON output when using the standard-library serializer, matching the existing orjson behavior. Passensure_ascii=Falseonly to the builtin backend because orjson does not accept that keyword.Fixes #572.
Validation: the new builtin-backend regression fails on the base; both backend cases pass after the change and still decode as JSON. All 27 CLI tests pass. Broader suite: 1274 passed, 44 skipped, one deselected. The excluded memory-exhaustion security test cannot set RLIMIT_AS on this macOS host (also fails on the base). Changed lines introduce no new lint errors; commands.py already has six line-length violations.
AI disclosure: Implemented, reviewed, and tested by OpenAI Codex under the account owner’s authorization; no human code review is claimed.