Skip to content

Add Neg trait for base types (Z, Q) - #534

Open
supinie wants to merge 2 commits into
qfall:devfrom
supinie:neg
Open

Add Neg trait for base types (Z, Q)#534
supinie wants to merge 2 commits into
qfall:devfrom
supinie:neg

Conversation

@supinie

@supinie supinie commented Aug 6, 2026

Copy link
Copy Markdown

Description

Implements the Neg trait for the 'base' types Z and Q

This PR implements...

  • Neg for Z
  • Neg for Q

Hope to follow implementation for all types shortly.

Testing

  • I added basic working examples (possibly in doc-comment)
  • I added tests for large (pointer representation) values
  • I included tests for all reasonable edge cases

Checklist:

  • I have performed a self-review of my own code
    • The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
      • The chosen implementation is not more complex than it has to be
    • My code should work as intended and no side effects occur (e.g. memory leaks)
    • The doc comments fit our style guide
    • I have credited related sources if needed

@Marvin-Beckmann Marvin-Beckmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for contributing! :)

@supinie

supinie commented Aug 6, 2026

Copy link
Copy Markdown
Author

Noticed a bad link in the docs, fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants