Skip to content

Broadly implement get_representative_least_absolute_residue#531

Open
jnsiemer wants to merge 2 commits intodevfrom
get_least_abs_residue
Open

Broadly implement get_representative_least_absolute_residue#531
jnsiemer wants to merge 2 commits intodevfrom
get_least_abs_residue

Conversation

@jnsiemer
Copy link
Copy Markdown
Member

@jnsiemer jnsiemer commented May 5, 2026

Description

This PR implements...

  • a correction of the previous implementation of get_representative_least_absolute_residue for Zq
  • an implementation of get_representative_least_absolute_residue for all other modulo data types.

Testing

  • I added basic working examples (possibly in doc-comment)
  • I added tests for large (pointer representation) values
  • I triggered all possible errors in my test in every possible way
  • I included tests for all reasonable edge cases

Checklist:

  • I have performed a self-review of my own code
    • The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
      • The chosen implementation is not more complex than it has to be
    • My code should work as intended and no side effects occur (e.g. memory leaks)
    • The doc comments fit our style guide

@jnsiemer jnsiemer requested a review from Marvin-Beckmann May 5, 2026 14:17
@jnsiemer jnsiemer self-assigned this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant