fix: resolve Robot Framework deprecated Return.args warning#458
Merged
Conversation
Access 'args' only on Keyword result objects and use 'values' for all other body element types that inherit DeprecatedAttributesMixin. Bump qase-robotframework to 5.0.1, update qase-python-commons to ~=5.0.3;
The tox config referenced an 'all' extra that doesn't exist in pyproject.toml, causing CI failures. Only 'testing' extra is available;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'robot.result.Return.args' is deprecated and will be removed in Robot Framework 8.0reported in Warning on deprecation given when using qase exporter for python #457argsattribute only onKeywordresult objects (where it is not deprecated) and usevaluesfor all other body element types (Return,For,ForIteration,While,Group,IfBranch,Try,TryBranch,Var,Continue,Break,Error) that inheritDeprecatedAttributesMixinqase-robotframeworkversion to5.0.1qase-python-commonsdependency to~=5.0.3Details
In Robot Framework 7+, all body element types except
KeywordinheritDeprecatedAttributesMixinwhich provides a deprecatedargsproperty that:()The previous code had a blacklist approach (only skipping
ForandForIteration), missingReturnand all other types. The fix switches to a whitelist approach — only accessing.argsonKeywordobjects and using.valuesfor everything else.Closes #457
Test plan
qase-robotframeworkreporterRETURN,FOR,WHILE, and other non-keyword body elements display their values correctly in steps