Fix SwitchBase class init error: fetch AppSettingsState on-demand

[Sun-Phil-Kwon-Miro]

Problem

SwitchBase had a static field that eagerly called AppSettingsState.getInstance() during class initialization:

private static final AppSettingsState settings = AppSettingsState.getInstance();

This runs inside <clinit> — when IntelliJ first loads the action class (e.g. on a keymap lookup). At that point the service container is not yet ready, causing:

java.lang.Throwable: switcher.intellij.actions.SwitchBase <clinit> requests
switcher.intellij.settings.AppSettingsState instance.
Class initialization must not depend on services.
Consider using instance of the service on-demand instead.

The error surfaced every time a key was pressed, since IntelliJ tries to resolve the action for keymap matching.

Fix

Replace the static field with a private static accessor method that fetches the service on-demand:

private static AppSettingsState settings() { return AppSettingsState.getInstance(); }

The service is now only retrieved when an action is actually executed, at which point the container is fully initialized. All call sites updated from settings. to settings().

Test plan

• Build and run the plugin in a sandbox IDE instance
• Verify no <clinit> error appears in the IDE log on startup or key press
• Verify switch actions (left/right/top/bottom panels) still work correctly
• Verify settings (rememberLastOpened, focusOnSwitched, etc.) are respected

🤖 Generated with Claude Code

[Sun-Phil-Kwon-Miro]

@qalisander

[Sun-Phil-Kwon-Miro]

Any news on this?